Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-10-26 Thread Lan Tianyu
On 2017年10月26日 22:27, Michael S. Tsirkin wrote: > On Thu, Oct 26, 2017 at 02:19:43PM +0200, Eduardo Habkost wrote: >> On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: >>> On 2017年08月19日 00:38, Eduardo Habkost wrote: On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > O

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-10-26 Thread Michael S. Tsirkin
On Thu, Oct 26, 2017 at 02:19:43PM +0200, Eduardo Habkost wrote: > On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: > > On 2017年08月19日 00:38, Eduardo Habkost wrote: > > > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > > >> On 2017年08月16日 19:21, Paolo Bonzini wrote: > > >>>

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-10-26 Thread Eduardo Habkost
On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: > On 2017年08月19日 00:38, Eduardo Habkost wrote: > > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > >> On 2017年08月16日 19:21, Paolo Bonzini wrote: > >>> On 16/08/2017 02:22, Lan Tianyu wrote: > Xen vIOMMU device model will

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-20 Thread Lan Tianyu
On 2017年08月19日 00:38, Eduardo Habkost wrote: > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: >> On 2017年08月16日 19:21, Paolo Bonzini wrote: >>> On 16/08/2017 02:22, Lan Tianyu wrote: Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU check for Xen here when vcpu n

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-18 Thread Paolo Bonzini
On 18/08/2017 18:38, Eduardo Habkost wrote: >>> I think you still need to do a check for vIOMMU being enabled. >> >> Yes, this will be done in the Xen tool stack and Qemu doesn't have such >> knowledge. Operations of create, destroy Xen vIOMMU will be done in the >> Xen tool stack. > > Shouldn't we

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-18 Thread Eduardo Habkost
On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > On 2017年08月16日 19:21, Paolo Bonzini wrote: > > On 16/08/2017 02:22, Lan Tianyu wrote: > >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU > >> check for Xen here when vcpu number is more than 255. > > > > I think you sti

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-16 Thread Lan Tianyu
On 2017年08月16日 19:21, Paolo Bonzini wrote: > On 16/08/2017 02:22, Lan Tianyu wrote: >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU >> check for Xen here when vcpu number is more than 255. > > I think you still need to do a check for vIOMMU being enabled. Yes, this will be done

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-16 Thread Paolo Bonzini
On 16/08/2017 02:22, Lan Tianyu wrote: > Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU > check for Xen here when vcpu number is more than 255. I think you still need to do a check for vIOMMU being enabled. Paolo > Signed-off-by: Lan Tianyu > --- > hw/i386/pc.c | 2 +- > 1 file

[Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-15 Thread Lan Tianyu
Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU check for Xen here when vcpu number is more than 255. Signed-off-by: Lan Tianyu --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5943539..fc17885 100644 --- a/hw/i