Re: [Qemu-devel] [PATCH] win32: fix main-loop busy loop on socket/fd event

2017-01-04 Thread Marc-André Lureau
Hi On Wed, Jan 4, 2017 at 10:23 PM Paolo Bonzini wrote: > > > Paolo suggested to me on irc to call event_notifier_test_and_clear() > > after select() >0 from aio-win32.c's aio_prepare. Unfortunately, not all > > fds associated with ctx->notifiers are in AIO fd handlers set. > > (qemu_set_nonbloc

Re: [Qemu-devel] [PATCH] win32: fix main-loop busy loop on socket/fd event

2017-01-04 Thread Paolo Bonzini
> Paolo suggested to me on irc to call event_notifier_test_and_clear() > after select() >0 from aio-win32.c's aio_prepare. Unfortunately, not all > fds associated with ctx->notifiers are in AIO fd handlers set. > (qemu_set_nonblock() in util/oslib-win32.c calls qemu_fd_register()). That makes sen

[Qemu-devel] [PATCH] win32: fix main-loop busy loop on socket/fd event

2017-01-04 Thread Marc-André Lureau
Commit 05e514b1d4d5bd4209e2c8bbc76ff05c85a235f3 introduced an AIO context optimization to avoid calling event_notifier_test_and_clear() on ctx->notifier. On Windows, the same notifier is being used to wakeup the wait on socket events (see commit d3385eb448e38f828c78f8f68ec5d79c66a58b5d). The ctx->