Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Wed, Jun 12, 2013 at 04:17:53PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), making them essentially random from build to build, > >

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread Anthony Liguori
mdroth writes: > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: >> When this VMSD was introduced it's version fields were set to >> sizeof(I6300State), making them essentially random from build to build, >> version to version. >> >> To fix this, we lock in a high version id and lo

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Wed, Jun 12, 2013 at 09:42:14PM +0100, Peter Maydell wrote: > On 12 June 2013 21:11, mdroth wrote: > > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > >> When this VMSD was introduced it's version fields were set to > >> sizeof(I6300State), making them essentially random from bu

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread Peter Maydell
On 12 June 2013 21:11, mdroth wrote: > On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: >> When this VMSD was introduced it's version fields were set to >> sizeof(I6300State), making them essentially random from build to build, >> version to version. >> >> To fix this, we lock in a hi

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-05-23 Thread Amit Shah
On (Tue) 21 May 2013 [17:32:57], Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to > support

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-05-22 Thread Laszlo Ersek
On 05/22/13 00:32, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to > support old->new migr

[Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-05-21 Thread Michael Roth
When this VMSD was introduced it's version fields were set to sizeof(I6300State), making them essentially random from build to build, version to version. To fix this, we lock in a high version id and low minimum version id to support old->new migration from all prior versions of this device's stat