Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

2018-06-22 Thread Peter Maydell
On 11 June 2018 at 14:56, Peter Maydell wrote: > Ping^2 for qemu-trivial? Gave up and threw it into the latest target-arm pullreq :-) thanks -- PMM

Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

2018-06-11 Thread Peter Maydell
Ping^2 for qemu-trivial? thanks -- PMM On 29 May 2018 at 16:25, Peter Maydell wrote: > Ping for application via qemu-trivial? > > thanks > -- PMM > > On 26 April 2018 at 15:19, Thomas Huth wrote: >> On 26.04.2018 16:02, Peter Maydell wrote: >>> checkpatch reminds us that statics shouldn't be ze

Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

2018-05-29 Thread Peter Maydell
Ping for application via qemu-trivial? thanks -- PMM On 26 April 2018 at 15:19, Thomas Huth wrote: > On 26.04.2018 16:02, Peter Maydell wrote: >> checkpatch reminds us that statics shouldn't be zero-initialized: >> >> ERROR: do not initialise statics to 0 or NULL >> #35: FILE: vl.c:157: >> +stat

Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

2018-04-26 Thread Thomas Huth
On 26.04.2018 16:02, Peter Maydell wrote: > checkpatch reminds us that statics shouldn't be zero-initialized: > > ERROR: do not initialise statics to 0 or NULL > #35: FILE: vl.c:157: > +static int num_serial_hds = 0; > > ERROR: do not initialise statics to 0 or NULL > #36: FILE: vl.c:158: > +stat

[Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

2018-04-26 Thread Peter Maydell
checkpatch reminds us that statics shouldn't be zero-initialized: ERROR: do not initialise statics to 0 or NULL #35: FILE: vl.c:157: +static int num_serial_hds = 0; ERROR: do not initialise statics to 0 or NULL #36: FILE: vl.c:158: +static Chardev **serial_hds = NULL; I forgot to fix this in 6af