Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-08 Thread Eduardo Habkost
On Thu, May 08, 2014 at 04:07:54PM +0100, Peter Maydell wrote: > On 8 May 2014 16:00, Eduardo Habkost wrote: > > On Thu, May 08, 2014 at 09:26:36AM +0100, Peter Maydell wrote: > >> On 7 May 2014 23:20, Andreas Färber wrote: > >> > Am 07.05.2014 23:48, schrieb Peter Maydell: > >> >> This is confus

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-08 Thread Andreas Färber
Am 08.05.2014 10:26, schrieb Peter Maydell: > On 7 May 2014 23:20, Andreas Färber wrote: >> Am 07.05.2014 23:48, schrieb Peter Maydell: >>> This is confusing. What is max_cpus >> >> Specified via -smp, defaults to actual CPUs. > > I thought that was smp_cpus ... smp_cpus determines how many CPUs

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-08 Thread Peter Maydell
On 8 May 2014 16:00, Eduardo Habkost wrote: > On Thu, May 08, 2014 at 09:26:36AM +0100, Peter Maydell wrote: >> On 7 May 2014 23:20, Andreas Färber wrote: >> > Am 07.05.2014 23:48, schrieb Peter Maydell: >> >> This is confusing. What is max_cpus >> > >> > Specified via -smp, defaults to actual CP

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-08 Thread Eduardo Habkost
On Thu, May 08, 2014 at 09:26:36AM +0100, Peter Maydell wrote: > On 7 May 2014 23:20, Andreas Färber wrote: > > Am 07.05.2014 23:48, schrieb Peter Maydell: > >> This is confusing. What is max_cpus > > > > Specified via -smp, defaults to actual CPUs. > > I thought that was smp_cpus ... smp_cpus i

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-08 Thread Peter Maydell
On 7 May 2014 23:20, Andreas Färber wrote: > Am 07.05.2014 23:48, schrieb Peter Maydell: >> This is confusing. What is max_cpus > > Specified via -smp, defaults to actual CPUs. I thought that was smp_cpus ... >> and why do we not >> just set max_cpus = machine->max_cpus ? > > For the PC, machine

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Andreas Färber
Am 07.05.2014 23:48, schrieb Peter Maydell: > On 7 May 2014 21:19, Eduardo Habkost wrote: >> If a given machine have max_cpus set, not just smp_cpus needs to be >> limited, but the total number of CPUs (considering CPU hotplug) for the >> machine. >> >> As smp_parse() already ensures smp_cpus <= m

Re: [Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Peter Maydell
On 7 May 2014 21:19, Eduardo Habkost wrote: > If a given machine have max_cpus set, not just smp_cpus needs to be > limited, but the total number of CPUs (considering CPU hotplug) for the > machine. > > As smp_parse() already ensures smp_cpus <= max_cpus, we just need to > check if max_cpus exceed

[Qemu-devel] [PATCH] vl.c: Check max_cpus limit instead of smp_cpus

2014-05-07 Thread Eduardo Habkost
If a given machine have max_cpus set, not just smp_cpus needs to be limited, but the total number of CPUs (considering CPU hotplug) for the machine. As smp_parse() already ensures smp_cpus <= max_cpus, we just need to check if max_cpus exceeds the limit. Signed-off-by: Eduardo Habkost --- vl.c