Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-02-01 Thread Stefan Hajnoczi
On Wed, Jan 31, 2018 at 03:31:27PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 14:56 hat Stefan Hajnoczi geschrieben: > > On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote: > > > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > > > > Commit dce8921b2baaf95974af8176406881872067adfa

Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-01-31 Thread Kevin Wolf
Am 31.01.2018 um 14:56 hat Stefan Hajnoczi geschrieben: > On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote: > > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > > > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads > > > before main() quits") introduced iot

Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-01-31 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote: > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads > > before main() quits") introduced iothread_stop_all() to avoid the > > following virtio-scsi assertio

Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads > before main() quits") introduced iothread_stop_all() to avoid the > following virtio-scsi assertion failure: > > assert(blk_get_aio_context(d->conf.blk) == s->ctx)

[Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-01-30 Thread Stefan Hajnoczi
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all() ma