Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-19 Thread Michael Tokarev
12.03.2015 17:57, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. Applied to -trivial, with a tiny change: > +fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : > false, > +

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-14 Thread Markus Armbruster
Eric Blake writes: > On 03/13/2015 06:55 AM, Paolo Bonzini wrote: >> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP >> command add_fd). Free it. >> >> Signed-off-by: Paolo Bonzini >> --- >> v1->v2: line length [Fam], pass &error_abort [Shannon] >> --- >> vl.c | 7 +

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-13 Thread Shannon Zhao
On 2015/3/13 20:55, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: line length [Fam], pass &error_abort [Shannon] > --- > vl.c | 7 +-- > 1 file changed, 5 insertions

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-13 Thread Eric Blake
On 03/13/2015 06:55 AM, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: line length [Fam], pass &error_abort [Shannon] > --- > vl.c | 7 +-- > 1 file changed, 5 insert

[Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-13 Thread Paolo Bonzini
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP command add_fd). Free it. Signed-off-by: Paolo Bonzini --- v1->v2: line length [Fam], pass &error_abort [Shannon] --- vl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index eba5d

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-13 Thread Paolo Bonzini
On 13/03/2015 06:17, Shannon Zhao wrote: >> > -monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false, >> > - fd_opaque, NULL); >> > +fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true >> > : false, >> > +

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-12 Thread Shannon Zhao
On 2015/3/12 22:57, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > vl.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index eba5d4c..890

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-12 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426172243-7830-1-git-send-email-pbonz...@redhat.com> --8<- === Starting docker === Cop

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-12 Thread Fam Zheng
On Thu, 03/12 15:57, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > vl.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index eba5d4c..89

Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-12 Thread Eric Blake
On 03/12/2015 08:57 AM, Paolo Bonzini wrote: > monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP > command add_fd). Free it. > > Signed-off-by: Paolo Bonzini > --- > vl.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eb

[Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd

2015-03-12 Thread Paolo Bonzini
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP command add_fd). Free it. Signed-off-by: Paolo Bonzini --- vl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index eba5d4c..8902435 100644 --- a/vl.c +++ b/vl.c @@ -1011,6 +1011,7 @@ stati