Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-12-02 Thread Rusty Russell
David Gibson writes: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virtio. > > However, the qemu device for vir

Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread Paolo Bonzini
Il 23/11/2012 06:08, David Gibson ha scritto: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virtio. Indeed. > H

Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread Stefan Hajnoczi
On Fri, Nov 23, 2012 at 04:08:44PM +1100, David Gibson wrote: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virti

[Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread David Gibson
The virtio-scsi specification does not specify the correct endianness for fields in the request structure. It's therefore best to assume that it is "guest native" endian since that's the (stupid and poorly defined) norm in virtio. However, the qemu device for virtio-scsi has no byteswaps at all,