Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-08 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in > transports > > On Fri, Sep 05, 2014 at 11:46:32PM +0800, Gonglei wrote: > > Hi, > > > > > Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child > > > refco

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Stefan Hajnoczi
On Fri, Sep 05, 2014 at 11:46:32PM +0800, Gonglei wrote: > Hi, > > > Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount > > in > > transports > > > > On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@h

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei
Hi, > Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in > transports > > On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > object_initialize() leaves the object with a refcount of 1.

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei
Hi, > Subject: Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in > transports > > On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > object_initialize() leaves the object with a refcount of 1.

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > object_initialize() leaves the object with a refcount of 1. > object_property_add_child() adds its own reference which is dropped > again when the property is deleted. > > The upshot of this is that we a

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Michael S. Tsirkin
On Thu, Sep 04, 2014 at 07:41:32PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > object_initialize() leaves the object with a refcount of 1. > object_property_add_child() adds its own reference which is dropped > again when the property is deleted. > > The upshot of this is that we a

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei (Arei)
Hi, CC'ing Stefan and qemu-stable@ for more attention. :) Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 04, 2014 7:42 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); Gonglei (Arei) > Subject: [PATCH] virtio-pci: f

[Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-04 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-net child is not finalized! Dr