Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 08:47:01PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 11, 2014 at 06:45:33PM +0200, Greg Kurz wrote: > > From: Michael S. Tsirkin > > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > bre

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 06:45:33PM +0200, Greg Kurz wrote: > From: Michael S. Tsirkin > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus masteri

[Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-11 Thread Greg Kurz
From: Michael S. Tsirkin commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices. For the same reason, rhel6.[56] ppc64 guests

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
On Wed, Sep 10, 2014 at 11:01:48AM +0200, Greg Kurz wrote: > On Wed, 10 Sep 2014 12:32:30 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: > > > Greg Kurz writes: > > > > > > > On Mon, 8 Sep 2014 19:05:02 +0300 > > > > "Michael S. Tsir

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
On Wed, Sep 10, 2014 at 02:45:51PM +0530, Nikunj A Dadhania wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: > >> Greg Kurz writes: > >> > >> > On Mon, 8 Sep 2014 19:05:02 +0300 > >> > "Michael S. Tsirkin" wrote: > >> > > >> >> comm

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
"Michael S. Tsirkin" writes: > On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: >> Greg Kurz writes: >> >> > On Mon, 8 Sep 2014 19:05:02 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 >> >> pci: Use bus master address spa

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
Greg Kurz writes: >> > > I did some debugging: it looks like the guest kernel calls the OF >> > > quisece call to flush pending DMA and disables bus master on the >> > > virtio-blk device (PCI_COMMAND == 0x3). >> > >> > Getting confused, above you are talking about virtio-net and here it is >> >

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Greg Kurz
On Wed, 10 Sep 2014 12:32:30 +0300 "Michael S. Tsirkin" wrote: > On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: > > Greg Kurz writes: > > > > > On Mon, 8 Sep 2014 19:05:02 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 >

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Greg Kurz
On Wed, 10 Sep 2014 13:44:49 +0530 Nikunj A Dadhania wrote: > Greg Kurz writes: > > > On Mon, 8 Sep 2014 19:05:02 +0300 > > "Michael S. Tsirkin" wrote: > > > >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 > >> pci: Use bus master address space for delivering MSI/MSI-X messages > >> brea

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
On Wed, Sep 10, 2014 at 12:35:32AM +0200, Greg Kurz wrote: > On Mon, 8 Sep 2014 19:05:02 +0300 > "Michael S. Tsirkin" wrote: > > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86 g

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
On Wed, Sep 10, 2014 at 01:44:49PM +0530, Nikunj A Dadhania wrote: > Greg Kurz writes: > > > On Mon, 8 Sep 2014 19:05:02 +0300 > > "Michael S. Tsirkin" wrote: > > > >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 > >> pci: Use bus master address space for delivering MSI/MSI-X messages > >

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-10 Thread Nikunj A Dadhania
Greg Kurz writes: > On Mon, 8 Sep 2014 19:05:02 +0300 > "Michael S. Tsirkin" wrote: > >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 >> pci: Use bus master address space for delivering MSI/MSI-X messages >> breaks virtio-net for rhel6.[56] x86 guests because they don't >> enable bus mast

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-09 Thread Alexey Kardashevskiy
On 09/10/2014 08:35 AM, Greg Kurz wrote: > On Mon, 8 Sep 2014 19:05:02 +0300 > "Michael S. Tsirkin" wrote: > >> commit cc943c36faa192cd4b32af8fe5edb31894017d35 >> pci: Use bus master address space for delivering MSI/MSI-X messages >> breaks virtio-net for rhel6.[56] x86 guests because they do

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-09 Thread Greg Kurz
On Mon, 8 Sep 2014 19:05:02 +0300 "Michael S. Tsirkin" wrote: > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus mastering for virtio PCI devices

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-09 Thread Michael S. Tsirkin
On Tue, Sep 09, 2014 at 09:13:38AM -0500, Michael Roth wrote: > Quoting Michael S. Tsirkin (2014-09-08 11:05:02) > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86 guests because th

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-09 Thread Michael Roth
Quoting Michael S. Tsirkin (2014-09-08 11:05:02) > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus mastering for virtio PCI devices > > Old guests

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-08 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 06:26:51PM +0200, Jan Kiszka wrote: > On 2014-09-08 18:05, Michael S. Tsirkin wrote: > > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > > pci: Use bus master address space for delivering MSI/MSI-X messages > > breaks virtio-net for rhel6.[56] x86 guests because they d

Re: [Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-08 Thread Jan Kiszka
On 2014-09-08 18:05, Michael S. Tsirkin wrote: > commit cc943c36faa192cd4b32af8fe5edb31894017d35 > pci: Use bus master address space for delivering MSI/MSI-X messages > breaks virtio-net for rhel6.[56] x86 guests because they don't > enable bus mastering for virtio PCI devices > > Old guests f

[Qemu-devel] [PATCH] virtio-pci: enable bus master for old guests

2014-09-08 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices Old guests forgot to enable bus mastering, enable it automatically on D