Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-05-07 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-05-07 Thread Michael S. Tsirkin
On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: > Commit 32993698 (vhost: disable on tap link down) tries to disable the vhost > also when the peer's link is down. But the check was not done properly, the > vhost were only started when: > > 1) peer's link is not down > 2) virtio-net ha

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-05-06 Thread Jason Wang
On 04/28/2013 04:25 PM, Michael S. Tsirkin wrote: > On Sun, Apr 28, 2013 at 03:51:32PM +0800, Jason Wang wrote: >> On 04/28/2013 03:32 AM, Michael S. Tsirkin wrote: >>> On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > On Fri, A

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-28 Thread Jason Wang
On 04/28/2013 04:25 PM, Michael S. Tsirkin wrote: > On Sun, Apr 28, 2013 at 03:51:32PM +0800, Jason Wang wrote: >> On 04/28/2013 03:32 AM, Michael S. Tsirkin wrote: >>> On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > On Fri, A

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-28 Thread Michael S. Tsirkin
On Sun, Apr 28, 2013 at 03:51:32PM +0800, Jason Wang wrote: > On 04/28/2013 03:32 AM, Michael S. Tsirkin wrote: > > On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: > >> On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > >>> On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: >

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-28 Thread Jason Wang
On 04/28/2013 03:32 AM, Michael S. Tsirkin wrote: > On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: >> On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: >>> On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: Commit 32993698 (vhost: disable on tap link down) tries to disabl

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-27 Thread Michael S. Tsirkin
On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: > On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > > On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: > >> Commit 32993698 (vhost: disable on tap link down) tries to disable the > >> vhost > >> also when the peer's link is d

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-26 Thread Jason Wang
On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: >> Commit 32993698 (vhost: disable on tap link down) tries to disable the vhost >> also when the peer's link is down. But the check was not done properly, the >> vhost were only started w

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-26 Thread Michael S. Tsirkin
On Fri, Apr 26, 2013 at 06:27:40PM +0800, Jason Wang wrote: > Commit 32993698 (vhost: disable on tap link down) tries to disable the vhost > also when the peer's link is down. But the check was not done properly, the > vhost were only started when: > > 1) peer's link is not down > 2) virtio-net ha

[Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-26 Thread Jason Wang
Commit 32993698 (vhost: disable on tap link down) tries to disable the vhost also when the peer's link is down. But the check was not done properly, the vhost were only started when: 1) peer's link is not down 2) virtio-net has already been started. Since == have a higher precedence than &&, plac