Re: [Qemu-devel] [PATCH] virtio-net: correctly advertise host features

2014-11-13 Thread Stefan Hajnoczi
On Thu, Nov 13, 2014 at 01:55:45PM +0800, Jason Wang wrote: > We should not advertise the feature that depends on ctrl vq is it was not > enabled. And not advertise the VIRTIO_NET_F_CTRL_RX_EXTRA is s/is/if/ > VIRTIO_NET_F_CTRL_RX is not enabled. s/is/it/ These can be fixed up while merging.

[Qemu-devel] [PATCH] virtio-net: correctly advertise host features

2014-11-12 Thread Jason Wang
We should not advertise the feature that depends on ctrl vq is it was not enabled. And not advertise the VIRTIO_NET_F_CTRL_RX_EXTRA is VIRTIO_NET_F_CTRL_RX is not enabled. Otherwise, this may confuse guest driver and lead unexpected bugs. Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 15 +