Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication

2015-08-19 Thread Pavel Fedin
Hello! > Why bother? This is adding more code than it deletes I just don't like code duplication, wanted to do this long time ago. Additionally this enables to add support for virtio-mmio to more machines. Actually it could be used not only by ARM with little modifications. > and is implicit

Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication

2015-08-19 Thread Peter Maydell
On 19 August 2015 at 12:23, Pavel Fedin wrote: > Extract common code for virtio-mmio creation and FDT node addition and > put it into reusable functions. Use new functions in vexpress and virt > machines. > > Signed-off-by: Pavel Fedin > --- > hw/arm/sysbus-fdt.c | 51 +++

[Qemu-devel] [PATCH] virtio-mmio: Kill code duplication

2015-08-19 Thread Pavel Fedin
Extract common code for virtio-mmio creation and FDT node addition and put it into reusable functions. Use new functions in vexpress and virt machines. Signed-off-by: Pavel Fedin --- hw/arm/sysbus-fdt.c | 51 +++ hw/arm/vexpress.c | 55 --