Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing

2017-01-03 Thread Gerd Hoffmann
> > +if (res->iov) { > > +cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; > > +return; > > +} > > + > > I think I would rather return an error in the library for this case. -ENOLIBRARY ;) This is the 2d mode code, so virglrenderer isn't involved at all. Added patch to the queue

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing

2016-12-29 Thread Li Qiang
2016-12-29 22:57 GMT+08:00 Marc-André Lureau : > Hi > > - Original Message - > > In the resource attach backing function, everytime it will > > allocate 'res->iov' thus can leading a memory leak. This > > patch avoid this. > > > > Signed-off-by: Li Qiang > > --- > > hw/display/virtio-gpu

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing

2016-12-29 Thread Marc-André Lureau
Hi - Original Message - > In the resource attach backing function, everytime it will > allocate 'res->iov' thus can leading a memory leak. This > patch avoid this. > > Signed-off-by: Li Qiang > --- > hw/display/virtio-gpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

[Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing

2016-12-29 Thread Li Qiang
In the resource attach backing function, everytime it will allocate 'res->iov' thus can leading a memory leak. This patch avoid this. Signed-off-by: Li Qiang --- hw/display/virtio-gpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c ind