Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-10 Thread Jason Wang
On 2017年03月09日 19:07, Cornelia Huck wrote: On Thu, 9 Mar 2017 10:19:47 +0800 Jason Wang wrote: On 2017年03月08日 18:12, Cornelia Huck wrote: On Wed, 8 Mar 2017 17:51:22 +0800 Jason Wang wrote: On 2017年03月08日 17:19, Cornelia Huck wrote: On Wed, 8 Mar 2017 11:18:27 +0800 Jason Wang wrote:

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-09 Thread Cornelia Huck
t;> To: "Paolo Bonzini" , m...@redhat.com, > >>> qemu-devel@nongnu.org > >>> Cc: pet...@redhat.com > >>> Sent: Wednesday, March 8, 2017 7:22:06 AM > >>> Subject: Re: [Qemu-devel] [PATCH] virtio: destroy region cache during > >>> rese

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-09 Thread Cornelia Huck
On Thu, 9 Mar 2017 12:12:00 +0100 Paolo Bonzini wrote: > On 09/03/2017 12:07, Cornelia Huck wrote: > >>> - Driver #2 uses the device without doing a reset or proper setup > >> Without this patch, even if driver #2 do a reset, it can still use the > >> old map if it don't set queue pfn. > > > >

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-09 Thread Paolo Bonzini
On 09/03/2017 12:07, Cornelia Huck wrote: >>> - Driver #2 uses the device without doing a reset or proper setup >> Without this patch, even if driver #2 do a reset, it can still use the >> old map if it don't set queue pfn. > > Yes, the cleanup-on-reset is definetly needed. It is good to have

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-09 Thread Paolo Bonzini
;>> Cc: pet...@redhat.com >>> Sent: Wednesday, March 8, 2017 7:22:06 AM >>> Subject: Re: [Qemu-devel] [PATCH] virtio: destroy region cache during >>> reset >>> >>> >>> >>> On 2017年03月08日 11:21, Jason Wang wrote: >>>> On 2017年0

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-09 Thread Cornelia Huck
On Thu, 9 Mar 2017 10:19:47 +0800 Jason Wang wrote: > On 2017年03月08日 18:12, Cornelia Huck wrote: > > On Wed, 8 Mar 2017 17:51:22 +0800 > > Jason Wang wrote: > > > >> On 2017年03月08日 17:19, Cornelia Huck wrote: > >>> On Wed, 8 Mar 2017 11:18:27 +0800 > >>> Jason Wang wrote: > >>> > On 2017年0

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Jason Wang
On 2017年03月08日 18:12, Cornelia Huck wrote: On Wed, 8 Mar 2017 17:51:22 +0800 Jason Wang wrote: On 2017年03月08日 17:19, Cornelia Huck wrote: On Wed, 8 Mar 2017 11:18:27 +0800 Jason Wang wrote: On 2017年03月07日 18:16, Cornelia Huck wrote: On Tue, 7 Mar 2017 16:47:58 +0800 Jason Wang wrote:

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Cornelia Huck
On Wed, 8 Mar 2017 17:53:23 +0800 Jason Wang wrote: > On 2017年03月08日 17:30, Cornelia Huck wrote: > > On Wed, 8 Mar 2017 14:22:06 +0800 > > Jason Wang wrote: > >> there may be even more. So you want to fix them all? > > Obviously not speaking for Paolo, but I think the virtio core should > > hav

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Cornelia Huck
On Wed, 8 Mar 2017 17:51:22 +0800 Jason Wang wrote: > On 2017年03月08日 17:19, Cornelia Huck wrote: > > On Wed, 8 Mar 2017 11:18:27 +0800 > > Jason Wang wrote: > > > >> On 2017年03月07日 18:16, Cornelia Huck wrote: > >>> On Tue, 7 Mar 2017 16:47:58 +0800 > >>> Jason Wang wrote: > >>> > We don't

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Jason Wang
On 2017年03月08日 17:30, Cornelia Huck wrote: On Wed, 8 Mar 2017 14:22:06 +0800 Jason Wang wrote: On 2017年03月08日 11:21, Jason Wang wrote: On 2017年03月07日 18:55, Paolo Bonzini wrote: On 07/03/2017 09:47, Jason Wang wrote: We don't destroy region cache during reset which can make the maps of pr

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Jason Wang
On 2017年03月08日 17:19, Cornelia Huck wrote: On Wed, 8 Mar 2017 11:18:27 +0800 Jason Wang wrote: On 2017年03月07日 18:16, Cornelia Huck wrote: On Tue, 7 Mar 2017 16:47:58 +0800 Jason Wang wrote: We don't destroy region cache during reset which can make the maps of previous driver leaked to a

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Jason Wang
On 2017年03月08日 17:10, Paolo Bonzini wrote: - Original Message - From: "Jason Wang" To: "Paolo Bonzini" , m...@redhat.com, qemu-devel@nongnu.org Cc: pet...@redhat.com Sent: Wednesday, March 8, 2017 7:22:06 AM Subject: Re: [Qemu-devel] [PATCH] virtio: destroy

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Cornelia Huck
On Wed, 8 Mar 2017 14:22:06 +0800 Jason Wang wrote: > On 2017年03月08日 11:21, Jason Wang wrote: > > > > On 2017年03月07日 18:55, Paolo Bonzini wrote: > >> > >> On 07/03/2017 09:47, Jason Wang wrote: > >>> We don't destroy region cache during reset which can make the maps > >>> of previous driver leake

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Cornelia Huck
On Wed, 8 Mar 2017 11:18:27 +0800 Jason Wang wrote: > On 2017年03月07日 18:16, Cornelia Huck wrote: > > On Tue, 7 Mar 2017 16:47:58 +0800 > > Jason Wang wrote: > > > >> We don't destroy region cache during reset which can make the maps > >> of previous driver leaked to a buggy or malicious driver

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-08 Thread Paolo Bonzini
- Original Message - > From: "Jason Wang" > To: "Paolo Bonzini" , m...@redhat.com, > qemu-devel@nongnu.org > Cc: pet...@redhat.com > Sent: Wednesday, March 8, 2017 7:22:06 AM > Subject: Re: [Qemu-devel] [PATCH] virtio: destroy region cache during

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Jason Wang
On 2017年03月08日 11:21, Jason Wang wrote: On 2017年03月07日 18:55, Paolo Bonzini wrote: On 07/03/2017 09:47, Jason Wang wrote: We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Jason Wang
On 2017年03月07日 18:55, Paolo Bonzini wrote: On 07/03/2017 09:47, Jason Wang wrote: We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting to use the device. I'm still not sure as

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Jason Wang
On 2017年03月07日 18:16, Cornelia Huck wrote: On Tue, 7 Mar 2017 16:47:58 +0800 Jason Wang wrote: We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting to use the device. Fix this

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Paolo Bonzini
On 07/03/2017 09:47, Jason Wang wrote: > We don't destroy region cache during reset which can make the maps > of previous driver leaked to a buggy or malicious driver that don't > set vring address before starting to use the device. I'm still not sure as to how this can happen. Reset does clear

Re: [Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Cornelia Huck
On Tue, 7 Mar 2017 16:47:58 +0800 Jason Wang wrote: > We don't destroy region cache during reset which can make the maps > of previous driver leaked to a buggy or malicious driver that don't > set vring address before starting to use the device. Fix this by > destroy the region cache during rese

[Qemu-devel] [PATCH] virtio: destroy region cache during reset

2017-03-07 Thread Jason Wang
We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting to use the device. Fix this by destroy the region cache during reset and validate it before trying to use them. While at it, also