Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-25 Thread Michael Roth
Quoting Felipe Franciosi (2017-09-20 13:53:06) > vhost_log_put() is called to decomission the dirty log between qemu and > a vhost device when stopping the device. Such a call can happen from > migration_completion(). > > Present code sets dev->log_size to zero too early in vhost_log_put(), > caus

Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-21 Thread Marc-André Lureau
- Original Message - > vhost_log_put() is called to decomission the dirty log between qemu and > a vhost device when stopping the device. Such a call can happen from > migration_completion(). > > Present code sets dev->log_size to zero too early in vhost_log_put(), > causing the sync che

Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-20 Thread Jason Wang
On 2017年09月21日 02:53, Felipe Franciosi wrote: vhost_log_put() is called to decomission the dirty log between qemu and a vhost device when stopping the device. Such a call can happen from migration_completion(). Present code sets dev->log_size to zero too early in vhost_log_put(), causing the s

Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-20 Thread Felipe Franciosi
Heya, > On 20 Sep 2017, at 13:33, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> vhost_log_put() is called to decomission the dirty log between qemu and >> a vhost device when stopping the device. Such a call can happen from >> migration_completion(). >> >> Present code

Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-20 Thread Marc-André Lureau
Hi - Original Message - > vhost_log_put() is called to decomission the dirty log between qemu and > a vhost device when stopping the device. Such a call can happen from > migration_completion(). > > Present code sets dev->log_size to zero too early in vhost_log_put(), > causing the sync c

[Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

2017-09-20 Thread Felipe Franciosi
vhost_log_put() is called to decomission the dirty log between qemu and a vhost device when stopping the device. Such a call can happen from migration_completion(). Present code sets dev->log_size to zero too early in vhost_log_put(), causing the sync check to always return false. As a consequence