Re: [Qemu-devel] [PATCH] vhost_net: cleanup start/stop condition

2014-08-04 Thread Amos Kong
On Mon, Aug 04, 2014 at 02:12:39PM +0200, Michael S. Tsirkin wrote: > Checking vhost device internal state in vhost_net looks like > a layering violation since vhost_net does not > set this flag: it is set and tested by vhost.c. > There seems to be no reason to check this: > caller in virtio net us

[Qemu-devel] [PATCH] vhost_net: cleanup start/stop condition

2014-08-04 Thread Michael S. Tsirkin
Checking vhost device internal state in vhost_net looks like a layering violation since vhost_net does not set this flag: it is set and tested by vhost.c. There seems to be no reason to check this: caller in virtio net uses its own flag, vhost_started, to ensure vhost is started/stopped as appropri