Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Jason Wang
On 2017年11月29日 02:06, Michael S. Tsirkin wrote: On Tue, Nov 28, 2017 at 03:46:44PM +0200, Victor Kaplansky wrote: From: Victor Kaplansky If we allow qemu to change logging area after it was already established, it may require from the backend to acquire a lock on each access to the log_base,

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> From: "Michael S. Tsirkin" > To: "Victor Kaplansky" > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" , > "Jason Wang" > Sent: Tuesday, November 28, 2017 8:45:43 PM > Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_base > > On Tue, Nov 28, 2017 at 01:34:19PM -0500, Victor Ka

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 01:34:19PM -0500, Victor Kaplansky wrote: > > From: "Michael S. Tsirkin" > > To: "Victor Kaplansky" > > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" , > > "Jason Wang" > > Sent: Tuesday, November 28, 2017 8:06:52 PM > > Subject: Re: [PATCH] vhost-user spec: Clarify polic

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> From: "Michael S. Tsirkin" > To: "Victor Kaplansky" > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" , > "Jason Wang" > Sent: Tuesday, November 28, 2017 8:06:52 PM > Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_base > > On Tue, Nov 28, 2017 at 03:46:44PM +0200, Victor Ka

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
el@nongnu.org, > > > "Maxime Coquelin" > > > Sent: Tuesday, November 28, 2017 6:12:44 PM > > > Subject: Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on > > > setting log_base > > > > > > On Tue, Nov 28, 2017 at 04:04:21PM +

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 03:46:44PM +0200, Victor Kaplansky wrote: > From: Victor Kaplansky > > If we allow qemu to change logging area after it was already established, > it may require from the backend to acquire a lock on each access to > the log_base, which has a potential quite a big performa

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 12:29:04PM -0500, Victor Kaplansky wrote: > > From: "Michael S. Tsirkin" > > To: "Victor Kaplansky" > > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" > > Sent: Tuesday, November 28, 2017 6:16:32 PM > > Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_bas

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> > +Note that master is not expected to issue more than one > > VHOST_USER_SET_LOG_BASE > > +request before the rings are fully stopped by the master. Thus no > > modifications > > +to log_base address are allowed before the rings are restated and the > > client > > +can ignore all subsequent VHOS

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Dr. David Alan Gilbert
* Victor Kaplansky (vkapl...@redhat.com) wrote: > > From: "Michael S. Tsirkin" > > To: "Dr. David Alan Gilbert" > > Cc: "Victor Kaplansky" , qemu-devel@nongnu.org, > > "Maxime Coquelin" > > Sent: Tuesday, November 28,

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> From: "Michael S. Tsirkin" > To: "Dr. David Alan Gilbert" > Cc: "Victor Kaplansky" , qemu-devel@nongnu.org, "Maxime > Coquelin" > Sent: Tuesday, November 28, 2017 6:12:44 PM > Subject: Re: [Qemu-devel] [PATCH] vhost-user spec: Clari

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
> From: "Michael S. Tsirkin" > To: "Victor Kaplansky" > Cc: qemu-devel@nongnu.org, "Maxime Coquelin" > Sent: Tuesday, November 28, 2017 6:16:32 PM > Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_base > > On Tue, Nov 28, 2017 at 03:46:44PM +0200, Victor Kaplansky wrote: > >

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 03:46:44PM +0200, Victor Kaplansky wrote: > From: Victor Kaplansky > > If we allow qemu to change logging area after it was already established, > it may require from the backend to acquire a lock on each access to > the log_base, which has a potential quite a big performa

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 04:04:21PM +, Dr. David Alan Gilbert wrote: > * Victor Kaplansky (vkapl...@redhat.com) wrote: > > From: Victor Kaplansky > > > > If we allow qemu to change logging area after it was already established, > > it may require from the backend to acquire a lock on each acce

Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Dr. David Alan Gilbert
* Victor Kaplansky (vkapl...@redhat.com) wrote: > From: Victor Kaplansky > > If we allow qemu to change logging area after it was already established, > it may require from the backend to acquire a lock on each access to > the log_base, which has a potential quite a big performance hit. > > Thus

[Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

2017-11-28 Thread Victor Kaplansky
From: Victor Kaplansky If we allow qemu to change logging area after it was already established, it may require from the backend to acquire a lock on each access to the log_base, which has a potential quite a big performance hit. Thus we would like to clarify in the spec, that qemu is not expect