Re: [Qemu-devel] [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers

2016-11-08 Thread Felipe Franciosi
> On 8 Nov 2016, at 18:18, Paolo Bonzini wrote: > > > > On 07/11/2016 18:23, Felipe Franciosi wrote: >> Following the recent refactor of virtio notfiers [1], more specifically >> the patch that uses virtio_bus_set_host_notifier [2] by default, core >> virtio code requires 'ioeventfd_started' t

Re: [Qemu-devel] [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers

2016-11-08 Thread Paolo Bonzini
On 07/11/2016 18:23, Felipe Franciosi wrote: > Following the recent refactor of virtio notfiers [1], more specifically > the patch that uses virtio_bus_set_host_notifier [2] by default, core > virtio code requires 'ioeventfd_started' to be set to true/false when > the host notifiers are configure

Re: [Qemu-devel] [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers

2016-11-07 Thread Paolo Bonzini
On 07/11/2016 18:26, Felipe Franciosi wrote: > > @@ -95,6 +95,7 @@ static int vhost_scsi_start(VHostSCSI *s) > > if (ret < 0) { > > return ret; > > } > > +VIRTIO_BUS(qbus)->ioeventfd_started = true; > > I'm not sure if it's safe to do this from > vhost_dev_disable/enable_noti

Re: [Qemu-devel] [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers

2016-11-07 Thread Felipe Franciosi
Hello, > On 7 Nov 2016, at 18:23, Felipe Franciosi wrote: > > Following the recent refactor of virtio notfiers [1], more specifically > the patch that uses virtio_bus_set_host_notifier [2] by default, core > virtio code requires 'ioeventfd_started' to be set to true/false when > the host notifie

[Qemu-devel] [PATCH] vhost-scsi: Update 'ioeventfd_started' with host notifiers

2016-11-07 Thread Felipe Franciosi
Following the recent refactor of virtio notfiers [1], more specifically the patch that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the host notifiers are configured. Since vhost-scsi uses the legacy interface, this val