Re: [Qemu-devel] [PATCH] vhost-net: cleanup host notifiers at last step

2011-08-28 Thread Michael S. Tsirkin
On Fri, Aug 26, 2011 at 01:29:23PM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2011-08-25 05:11]: > > When the vhost notifier is disabled, the userspace handler runs > > immediately: virtio_pci_set_host_notifier_internal might > > call virtio_queue_notify_vq. > > Since the VQ state and the t

Re: [Qemu-devel] [PATCH] vhost-net: cleanup host notifiers at last step

2011-08-26 Thread Ryan Harper
* Michael S. Tsirkin [2011-08-25 05:11]: > When the vhost notifier is disabled, the userspace handler runs > immediately: virtio_pci_set_host_notifier_internal might > call virtio_queue_notify_vq. > Since the VQ state and the tap backend state aren't > recovered yet, this causes > "Guest moved use

[Qemu-devel] [PATCH] vhost-net: cleanup host notifiers at last step

2011-08-25 Thread Michael S. Tsirkin
When the vhost notifier is disabled, the userspace handler runs immediately: virtio_pci_set_host_notifier_internal might call virtio_queue_notify_vq. Since the VQ state and the tap backend state aren't recovered yet, this causes "Guest moved used index from XXX to YYY" assertions. The solution is