Re: [Qemu-devel] [PATCH] vfio/pci: Cleanup vfio_early_setup_msix() error path

2015-07-20 Thread Laszlo Ersek
On 07/20/15 18:41, Alex Williamson wrote: > With the addition of the Chelsio quirk we have an error path out of > vfio_early_setup_msix() that doesn't free the allocated VFIOMSIXInfo > struct. This doesn't introduce a leak as it still gets freed in the > vfio_put_device() path, but it's complicate

[Qemu-devel] [PATCH] vfio/pci: Cleanup vfio_early_setup_msix() error path

2015-07-20 Thread Alex Williamson
With the addition of the Chelsio quirk we have an error path out of vfio_early_setup_msix() that doesn't free the allocated VFIOMSIXInfo struct. This doesn't introduce a leak as it still gets freed in the vfio_put_device() path, but it's complicated and sloppy to rely on that. Restructure to free