Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-04-12 Thread Alexey Kardashevskiy
On 04/13/2014 01:09 PM, Alexey Kardashevskiy wrote: > On 03/24/2014 08:26 PM, Peter Maydell wrote: >> On 24 March 2014 05:53, Alexey Kardashevskiy wrote: >>> On 03/23/2014 08:23 AM, Peter Maydell wrote: Oops, I hadn't noticed that; this patch is incorrect, then, because vmstate_ohci need

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-04-12 Thread Alexey Kardashevskiy
On 03/24/2014 08:26 PM, Peter Maydell wrote: > On 24 March 2014 05:53, Alexey Kardashevskiy wrote: >> On 03/23/2014 08:23 AM, Peter Maydell wrote: >>> Oops, I hadn't noticed that; this patch is incorrect, then, because >>> vmstate_ohci needs to include a line for the OHCIState, and we >>> need a s

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-24 Thread Gerd Hoffmann
Hi, > It looks like you don't need to save USBPacket or USBPort > fields, since the other USB controllers don't (though I'm not > sure why not -- Gerd, do you know why this is OK?). Most state info is in guest memory. Any unfinished usb transfers are simply restarted on the target host. This

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-24 Thread Peter Maydell
On 24 March 2014 05:53, Alexey Kardashevskiy wrote: > On 03/23/2014 08:23 AM, Peter Maydell wrote: >> Oops, I hadn't noticed that; this patch is incorrect, then, because >> vmstate_ohci needs to include a line for the OHCIState, and we >> need a second vmstate struct for the OHCIState. > Sorry bu

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-23 Thread Alexey Kardashevskiy
On 03/23/2014 08:23 AM, Peter Maydell wrote: > On 22 March 2014 21:04, Andreas Färber wrote: >> Am 22.03.2014 21:54, schrieb Peter Maydell: >>> On 22 March 2014 20:18, Andreas Färber wrote: Because AFAIU migration is possible without VMSD, just not with VMSD that sets .unmigratable

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Alexey Kardashevskiy
On 03/23/2014 08:04 AM, Andreas Färber wrote: > Am 22.03.2014 21:54, schrieb Peter Maydell: >> On 22 March 2014 20:18, Andreas Färber wrote: >>> Because AFAIU >>> migration is possible without VMSD, just not with VMSD that sets >>> .unmigratable = 1. >> >> Well, the migration won't fail with an er

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Peter Maydell
On 22 March 2014 21:04, Andreas Färber wrote: > Am 22.03.2014 21:54, schrieb Peter Maydell: >> On 22 March 2014 20:18, Andreas Färber wrote: >>> Because AFAIU >>> migration is possible without VMSD, just not with VMSD that sets >>> .unmigratable = 1. >> >> Well, the migration won't fail with an e

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Andreas Färber
Am 22.03.2014 21:54, schrieb Peter Maydell: > On 22 March 2014 20:18, Andreas Färber wrote: >> Because AFAIU >> migration is possible without VMSD, just not with VMSD that sets >> .unmigratable = 1. > > Well, the migration won't fail with an error, but on the destination > end you'll end up with

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Peter Maydell
On 22 March 2014 20:18, Andreas Färber wrote: > Because AFAIU > migration is possible without VMSD, just not with VMSD that sets > .unmigratable = 1. Well, the migration won't fail with an error, but on the destination end you'll end up with a device in its reset state but a guest which may think

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Andreas Färber
Am 14.03.2014 06:09, schrieb Alexey Kardashevskiy: > On 03/07/2014 12:57 AM, Mike Day wrote: >> >> Alexey Kardashevskiy writes: >> >>> This adds migration support for OHCI. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Reviewed-by: Mike Day > > Thanks! > > What is next? The USB maintainer

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-13 Thread Alexey Kardashevskiy
On 03/07/2014 12:57 AM, Mike Day wrote: > > Alexey Kardashevskiy writes: > >> This adds migration support for OHCI. >> >> Signed-off-by: Alexey Kardashevskiy > > Reviewed-by: Mike Day Thanks! What is next? > >> --- >> hw/usb/hcd-ohci.c | 12 >> 1 file changed, 12 insertions

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-06 Thread Mike Day
Alexey Kardashevskiy writes: > This adds migration support for OHCI. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/usb/hcd-ohci.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index e38cdeb..c42e091

[Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-05 Thread Alexey Kardashevskiy
This adds migration support for OHCI. Signed-off-by: Alexey Kardashevskiy --- hw/usb/hcd-ohci.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index e38cdeb..c42e091 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -1984,6 +1984,1