Re: [Qemu-devel] [PATCH] usb-ehci: drop assert()

2012-03-30 Thread Hans de Goede
Looks good, ACK. Acked-by: Hans de Goede On 03/30/2012 01:26 PM, Gerd Hoffmann wrote: Not sure what the purpose of the assert() was, in any case it is bogous. We can arrive there if transfer descriptors passed to us from the guest failed to pass sanity checks, i.e. it is guest-triggerable. W

[Qemu-devel] [PATCH] usb-ehci: drop assert()

2012-03-30 Thread Gerd Hoffmann
Not sure what the purpose of the assert() was, in any case it is bogous. We can arrive there if transfer descriptors passed to us from the guest failed to pass sanity checks, i.e. it is guest-triggerable. We deal with that case by resetting the host controller. Everything is ok, no need to throw