Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code

2017-10-12 Thread Paolo Bonzini
On 12/10/2017 16:02, Marc-André Lureau wrote: > I did a simple migration test from a state file with the field to a > state file without, and the other way around and it seemed to work. I > probably screwed up the test. > > Looking at vmstate code, it obviously changes the wire format. So > let's

Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code

2017-10-12 Thread Marc-André Lureau
Hi On Thu, Oct 12, 2017 at 3:29 PM, Gerd Hoffmann wrote: > On Thu, 2017-10-12 at 13:21 +0200, Marc-André Lureau wrote: >> This code appears to be unused since its introduction. It should be >> safe to remove from VMState. > > Well, almost: > >> @@ -1452,7 +1431,6 @@ static VMStateDescription ccid

Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code

2017-10-12 Thread Gerd Hoffmann
On Thu, 2017-10-12 at 13:21 +0200, Marc-André Lureau wrote: > This code appears to be unused since its introduction. It should be > safe to remove from VMState. Well, almost: > @@ -1452,7 +1431,6 @@ static VMStateDescription ccid_vmstate = { >  VMSTATE_STRUCT_ARRAY(pending_answers, USBCCI

[Qemu-devel] [PATCH] usb-ccid: remove needless migration state code

2017-10-12 Thread Marc-André Lureau
This code appears to be unused since its introduction. It should be safe to remove from VMState. Signed-off-by: Marc-André Lureau --- hw/usb/dev-smartcard-reader.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-read