Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

On 8 June 2018 at 21:01, John Arbuckle wrote: > Fix the cocoa front-end to correctly be able to use absolute mode. > > Signed-off-by: John Arbuckle > case NSEventTypeMouseMoved: > if (isAbsoluteEnabled) { > -if (![self screenContainsPoint:p] || ![[self windo

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

On 18 June 2018 at 23:24, Programmingkid wrote: > When using an usb-tablet device in QEMU, the Cocoa UI uses absolute >mode code to handle mouse events. The absolute mode code does not >correctly determine where QEMU's window is located. Tests indicate >the current code thinks the window is locate

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

On Jun 18, 2018, at 7:18 AM, Peter Maydell wrote: > On 8 June 2018 at 21:01, John Arbuckle wrote: >> Fix the cocoa front-end to correctly be able to use absolute mode. >> >> Signed-off-by: John Arbuckle > > This commit message is insufficiently detailed, which makes > it hard to review the p

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

On 8 June 2018 at 21:01, John Arbuckle wrote: > Fix the cocoa front-end to correctly be able to use absolute mode. > > Signed-off-by: John Arbuckle This commit message is insufficiently detailed, which makes it hard to review the patch. When you send patches, please can you provide commit messag

[Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

Fix the cocoa front-end to correctly be able to use absolute mode. Signed-off-by: John Arbuckle --- ui/cocoa.m | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 2991ed4f19..dda99ad638 100644 --- a/ui/cocoa.m +++ b/