Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-09 Thread Emilio G. Cota
On Mon, Jul 09, 2018 at 17:59:02 +0100, Peter Maydell wrote: > Hi -- I've been having a look at getting QEMU to support execution > from MMIO regions by doing a "generate a single-insn CF_NOCACHE TB". > As part of that, rth and I ran into a question about this change: > why does tb_link_page() stil

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-09 Thread Peter Maydell
On 5 July 2018 at 17:07, Emilio G. Cota wrote: > This fixes a record-replay regression introduced by 95590e2 > ("translate-all: discard TB when tb_link_page returns an existing > matching TB", 2018-06-15). The problem is that code using CF_NOCACHE > assumes that the TB returned from tb_gen_code is

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-09 Thread Peter Maydell
On 5 July 2018 at 17:07, Emilio G. Cota wrote: > This fixes a record-replay regression introduced by 95590e2 > ("translate-all: discard TB when tb_link_page returns an existing > matching TB", 2018-06-15). The problem is that code using CF_NOCACHE > assumes that the TB returned from tb_gen_code is

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-06 Thread Alistair Francis
On Fri, Jul 6, 2018 at 6:05 AM, Peter Maydell wrote: > On 5 July 2018 at 17:07, Emilio G. Cota wrote: >> This fixes a record-replay regression introduced by 95590e2 >> ("translate-all: discard TB when tb_link_page returns an existing >> matching TB", 2018-06-15). The problem is that code using CF

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-06 Thread Peter Maydell
On 5 July 2018 at 17:07, Emilio G. Cota wrote: > This fixes a record-replay regression introduced by 95590e2 > ("translate-all: discard TB when tb_link_page returns an existing > matching TB", 2018-06-15). The problem is that code using CF_NOCACHE > assumes that the TB returned from tb_gen_code is

Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-05 Thread Richard Henderson
On 07/05/2018 09:07 AM, Emilio G. Cota wrote: > This fixes a record-replay regression introduced by 95590e2 > ("translate-all: discard TB when tb_link_page returns an existing > matching TB", 2018-06-15). The problem is that code using CF_NOCACHE > assumes that the TB returned from tb_gen_code is a

[Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

2018-07-05 Thread Emilio G. Cota
This fixes a record-replay regression introduced by 95590e2 ("translate-all: discard TB when tb_link_page returns an existing matching TB", 2018-06-15). The problem is that code using CF_NOCACHE assumes that the TB returned from tb_gen_code is always a newly-generated one. This assumption, however,