Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Stefan Hajnoczi
On Thu, Nov 17, 2016 at 10:48:34AM +0100, Greg Kurz wrote: > On Thu, 17 Nov 2016 17:34:44 +0800 > Fam Zheng wrote: > > > On Thu, 11/17 10:10, Greg Kurz wrote: > > > On Thu, 17 Nov 2016 16:07:38 +0800 > > > Fam Zheng wrote: > > > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 11/17 10:48, Greg Kurz wrote: > On Thu, 17 Nov 2016 17:34:44 +0800 > Fam Zheng wrote: > > > On Thu, 11/17 10:10, Greg Kurz wrote: > > > On Thu, 17 Nov 2016 16:07:38 +0800 > > > Fam Zheng wrote: > > > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > > > > > I have

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Greg Kurz
On Thu, 17 Nov 2016 17:34:44 +0800 Fam Zheng wrote: > On Thu, 11/17 10:10, Greg Kurz wrote: > > On Thu, 17 Nov 2016 16:07:38 +0800 > > Fam Zheng wrote: > > > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > > > I have two other patches ready to fix the current situation: > >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 11/17 10:10, Greg Kurz wrote: > On Thu, 17 Nov 2016 16:07:38 +0800 > Fam Zheng wrote: > > > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > > > I have two other patches ready to fix the current situation: > > > > - one using os.getcwd() to guess the build directory > > > > - one

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Greg Kurz
On Thu, 17 Nov 2016 16:07:38 +0800 Fam Zheng wrote: > On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > > > I have two other patches ready to fix the current situation: > > > - one using os.getcwd() to guess the build directory > > > - one implementing --group as mentioned in my other mail > >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-11-17 Thread Fam Zheng
On Thu, 10/20 15:25, Stefan Hajnoczi wrote: > > > > I have two other patches ready to fix the current situation: > > - one using os.getcwd() to guess the build directory > > - one implementing --group as mentioned in my other mail > > > > But the one that filters unwanted characters is a less int

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2016 at 05:52:00PM +0200, Greg Kurz wrote: > On Tue, 18 Oct 2016 16:31:24 +0100 > "Daniel P. Berrange" wrote: > > > On Tue, Oct 18, 2016 at 04:16:46PM +0100, Daniel P. Berrange wrote: > > > On Fri, Oct 14, 2016 at 04:31:01PM -0500, Eric Blake wrote: > > > > On 10/14/2016 04:26 P

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-18 Thread Greg Kurz
On Tue, 18 Oct 2016 16:16:46 +0100 "Daniel P. Berrange" wrote: > On Fri, Oct 14, 2016 at 04:31:01PM -0500, Eric Blake wrote: > > On 10/14/2016 04:26 PM, Greg Kurz wrote: > > > Since commit "80dd5c4918ab trace: introduce a formal group name for trace > > > events", tracetool generates C variable

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-18 Thread Greg Kurz
On Tue, 18 Oct 2016 16:31:24 +0100 "Daniel P. Berrange" wrote: > On Tue, Oct 18, 2016 at 04:16:46PM +0100, Daniel P. Berrange wrote: > > On Fri, Oct 14, 2016 at 04:31:01PM -0500, Eric Blake wrote: > > > On 10/14/2016 04:26 PM, Greg Kurz wrote: > > > > Since commit "80dd5c4918ab trace: introdu

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-18 Thread Daniel P. Berrange
On Tue, Oct 18, 2016 at 04:16:46PM +0100, Daniel P. Berrange wrote: > On Fri, Oct 14, 2016 at 04:31:01PM -0500, Eric Blake wrote: > > On 10/14/2016 04:26 PM, Greg Kurz wrote: > > > Since commit "80dd5c4918ab trace: introduce a formal group name for trace > > > events", tracetool generates C variabl

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-18 Thread Daniel P. Berrange
On Fri, Oct 14, 2016 at 04:31:01PM -0500, Eric Blake wrote: > On 10/14/2016 04:26 PM, Greg Kurz wrote: > > Since commit "80dd5c4918ab trace: introduce a formal group name for trace > > events", tracetool generates C variable names and macro definitions out > > of the path to the trace-events-all fi

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-16 Thread Greg Kurz
On Sat, 15 Oct 2016 13:03:10 +0100 Peter Maydell wrote: > On 14 October 2016 at 23:06, Greg Kurz wrote: > > On Fri, 14 Oct 2016 16:31:01 -0500 > > Eric Blake wrote: > > > >> On 10/14/2016 04:26 PM, Greg Kurz wrote: > >> > Since commit "80dd5c4918ab trace: introduce a formal group name for t

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-15 Thread Peter Maydell
On 14 October 2016 at 23:06, Greg Kurz wrote: > On Fri, 14 Oct 2016 16:31:01 -0500 > Eric Blake wrote: > >> On 10/14/2016 04:26 PM, Greg Kurz wrote: >> > Since commit "80dd5c4918ab trace: introduce a formal group name for trace >> > events", tracetool generates C variable names and macro definiti

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-14 Thread Greg Kurz
On Fri, 14 Oct 2016 16:31:01 -0500 Eric Blake wrote: > On 10/14/2016 04:26 PM, Greg Kurz wrote: > > Since commit "80dd5c4918ab trace: introduce a formal group name for trace > > events", tracetool generates C variable names and macro definitions out > > of the path to the trace-events-all file. >

Re: [Qemu-devel] [PATCH] trace: fix group name generation

2016-10-14 Thread Eric Blake
On 10/14/2016 04:26 PM, Greg Kurz wrote: > Since commit "80dd5c4918ab trace: introduce a formal group name for trace > events", tracetool generates C variable names and macro definitions out > of the path to the trace-events-all file. > > The current code takes care of turning '/' and '-' characte

[Qemu-devel] [PATCH] trace: fix group name generation

2016-10-14 Thread Greg Kurz
Since commit "80dd5c4918ab trace: introduce a formal group name for trace events", tracetool generates C variable names and macro definitions out of the path to the trace-events-all file. The current code takes care of turning '/' and '-' characters into underscores so that the resulting names are