Re: [Qemu-devel] [PATCH] trace: add sanity check

2017-05-11 Thread Stefan Hajnoczi
On Tue, May 09, 2017 at 03:37:12PM -0700, Anthony Xu wrote: > If trace backend is set to TRACE_NOP, trace_get_vcpu_event_count > returns 0, cause bitmap_new call abort. > > Signed-off-by: Anthony Xu > --- > qom/cpu.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Thanks, applied t

Re: [Qemu-devel] [PATCH] trace: add sanity check

2017-05-10 Thread Xu, Anthony
> Please post steps for reproducing the abort. I cannot reproduce this > with qemu-system-x86_64. The steps to reproduce the issue, ./configure --enable-trace-backend=nop --target-list=x86_64-softmmu gdb -args ./x86_64-softmmu/qemu-system-x86_64 -bios /home/root/guest/seabios.bin -smp 1 -machi

Re: [Qemu-devel] [PATCH] trace: add sanity check

2017-05-10 Thread Stefan Hajnoczi
On Tue, May 09, 2017 at 03:37:12PM -0700, Anthony Xu wrote: > If trace backend is set to TRACE_NOP, trace_get_vcpu_event_count > returns 0, cause bitmap_new call abort. > > Signed-off-by: Anthony Xu > --- > qom/cpu.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Please post steps

[Qemu-devel] [PATCH] trace: add sanity check

2017-05-09 Thread Anthony Xu
If trace backend is set to TRACE_NOP, trace_get_vcpu_event_count returns 0, cause bitmap_new call abort. Signed-off-by: Anthony Xu --- qom/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index f02e9c0..f9111a0 100644 --- a/qom/cpu.c +++ b/qom/