Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-06-01 Thread Lluís Vilanova
Alexey Kardashevskiy writes: > On 05/31/2014 12:08 AM, Lluís Vilanova wrote: >> Alexey Kardashevskiy writes: >> >>> On 05/29/2014 10:42 PM, Lluís Vilanova wrote: Alexey Kardashevskiy writes: > This replaces fprintf(stderr) with error_report. > This prints line number of the tra

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-06-01 Thread Alexey Kardashevskiy
On 05/31/2014 12:08 AM, Lluís Vilanova wrote: > Alexey Kardashevskiy writes: > >> On 05/29/2014 10:42 PM, Lluís Vilanova wrote: >>> Alexey Kardashevskiy writes: >>> This replaces fprintf(stderr) with error_report. This prints line number of the trace which does not exist or is not t

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-05-30 Thread Lluís Vilanova
Alexey Kardashevskiy writes: > On 05/29/2014 10:42 PM, Lluís Vilanova wrote: >> Alexey Kardashevskiy writes: >> >>> This replaces fprintf(stderr) with error_report. >>> This prints line number of the trace which does not exist or is not >>> traceable. >> >> A little nit pick; it shows an error w

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-05-29 Thread Alexey Kardashevskiy
On 05/29/2014 10:42 PM, Lluís Vilanova wrote: > Alexey Kardashevskiy writes: > >> This replaces fprintf(stderr) with error_report. >> This prints line number of the trace which does not exist or is not >> traceable. > > A little nit pick; it shows an error when some of the events in the list of >

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-05-29 Thread Lluís Vilanova
Alexey Kardashevskiy writes: > This replaces fprintf(stderr) with error_report. > This prints line number of the trace which does not exist or is not > traceable. A little nit pick; it shows an error when some of the events in the list of events to enable (not the trace) does not exist or is not

[Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

2014-05-28 Thread Alexey Kardashevskiy
This replaces fprintf(stderr) with error_report. This prints line number of the trace which does not exist or is not traceable. This moves local variables to the beginning of the function because of the QEMU coding style. Suggested-by: Lluís Vilanova Signed-off-by: Alexey Kardashevskiy --- Ll