Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Valluri, Amarnath
Sorry for causing build break :( I would prefer the way tpm_init() was handled in vl.c, even tpm_cleanup() shuould be guarded behind #ifdef CONFIG_TPM. - Amarnath On Wed, 2017-10-18 at 11:27 +0200, Juan Quintela wrote: > Laurent Vivier wrote: > > > > On 18/10/2017 10:33, Juan Quintela wrote: >

Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Juan Quintela
Laurent Vivier wrote: > On 18/10/2017 10:33, Juan Quintela wrote: >> Commit >>c37cacabf2285b0731b44c1f667781fdd4f2b658 >> >> broke compilation without tpm. Just add an empty tpm_cleanup() stub. > > tpm_init() and tpm_config_parse() are managed in a different way: they > are included in a "#i

Re: [Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Laurent Vivier
On 18/10/2017 10:33, Juan Quintela wrote: > Commit >c37cacabf2285b0731b44c1f667781fdd4f2b658 > > broke compilation without tpm. Just add an empty tpm_cleanup() stub. tpm_init() and tpm_config_parse() are managed in a different way: they are included in a "#ifdef CONFIG_TPM .. #endif" in vl.c

[Qemu-devel] [PATCH] tpm: Fix compilation with --disable-tpm

2017-10-18 Thread Juan Quintela
Commit c37cacabf2285b0731b44c1f667781fdd4f2b658 broke compilation without tpm. Just add an empty tpm_cleanup() stub. CC: Amarnath Valluri Signed-off-by: Juan Quintela --- tpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tpm.c b/tpm.c index 317156..9396bb669c 100644 --- a