Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
>>> I think it's nice to at least do the "bump version" thing, so you >>> get a (hopefully comprehensible) error rather than just wrong >>> data if you do try a cross version migration, >> >> On that topic, the error message was : >> >> Missing section footer for aspeed.timerctrl >> >> which

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > On 04/23/2018 11:34 AM, Peter Maydell wrote: > > On 23 April 2018 at 10:28, Cédric Le Goater wrote: > >> On 04/23/2018 11:12 AM, Peter Maydell wrote: > diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c > index 50acbf530a3a..7df19bd

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:34 AM, Peter Maydell wrote: > On 23 April 2018 at 10:28, Cédric Le Goater wrote: >> On 04/23/2018 11:12 AM, Peter Maydell wrote: diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index 50acbf530a3a..7df19bd9df91 100644 --- a/hw/timer/aspeed_timer.c

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:34 AM, Peter Maydell wrote: > On 23 April 2018 at 10:28, Cédric Le Goater wrote: >> On 04/23/2018 11:12 AM, Peter Maydell wrote: diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index 50acbf530a3a..7df19bd9df91 100644 --- a/hw/timer/aspeed_timer.c

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 10:28, Cédric Le Goater wrote: > On 04/23/2018 11:12 AM, Peter Maydell wrote: >>> diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c >>> index 50acbf530a3a..7df19bd9df91 100644 >>> --- a/hw/timer/aspeed_timer.c >>> +++ b/hw/timer/aspeed_timer.c >>> @@ -498,8 +498,8

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Cédric Le Goater
On 04/23/2018 11:12 AM, Peter Maydell wrote: >> diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c >> index 50acbf530a3a..7df19bd9df91 100644 >> --- a/hw/timer/aspeed_timer.c >> +++ b/hw/timer/aspeed_timer.c >> @@ -498,8 +498,8 @@ static const VMStateDescription vmstate_aspeed_timer = {

Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-23 Thread Peter Maydell
On 23 April 2018 at 07:40, Cédric Le Goater wrote: > commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to > aspeed_timer") increased the vmstate version of the timers array but > doing so, it broke migration. To fix, we also need to change the > vmstate version of the aspeed timer control

[Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id

2018-04-22 Thread Cédric Le Goater
commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to aspeed_timer") increased the vmstate version of the timers array but doing so, it broke migration. To fix, we also need to change the vmstate version of the aspeed timer controller model. Signed-off-by: Cédric Le Goater --- To test o