Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-13 Thread Peter Maydell
On 6 June 2017 at 09:55, Cédric Le Goater wrote: > When a timer is enabled before a reload value is set, the controller > waits for a reload value to be set before starting decrementing. This > fix tries to cover that case by changing the timer expiry only when > a reload value is valid. > > Signe

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-12 Thread Cédric Le Goater
On 06/13/2017 06:37 AM, Andrew Jeffery wrote: > On Fri, 2017-06-09 at 07:40 +0200, Cédric Le Goater wrote: >> On 06/09/2017 04:26 AM, Andrew Jeffery wrote: >>> On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: When a timer is enabled before a reload value is set, the controller w

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-12 Thread Andrew Jeffery
On Fri, 2017-06-09 at 07:40 +0200, Cédric Le Goater wrote: > On 06/09/2017 04:26 AM, Andrew Jeffery wrote: > > On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: > > > When a timer is enabled before a reload value is set, the controller > > > waits for a reload value to be set before starti

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-08 Thread Cédric Le Goater
On 06/09/2017 04:26 AM, Andrew Jeffery wrote: > On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: >> When a timer is enabled before a reload value is set, the controller >> waits for a reload value to be set before starting decrementing. This >> fix tries to cover that case by changing the

Re: [Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-08 Thread Andrew Jeffery
On Tue, 2017-06-06 at 10:55 +0200, Cédric Le Goater wrote: > When a timer is enabled before a reload value is set, the controller > waits for a reload value to be set before starting decrementing. This > fix tries to cover that case by changing the timer expiry only when > a reload value is valid.

[Qemu-devel] [PATCH] timer/aspeed: fix timer enablement when a reload is not set

2017-06-06 Thread Cédric Le Goater
When a timer is enabled before a reload value is set, the controller waits for a reload value to be set before starting decrementing. This fix tries to cover that case by changing the timer expiry only when a reload value is valid. Signed-off-by: Cédric Le Goater --- hw/timer/aspeed_timer.c | 37