Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-09 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, May 08, 2019 at 03:04:43PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: >> >> On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: >> >> > test-qapi.py doesn't

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-08 Thread Eduardo Habkost
On Wed, May 08, 2019 at 03:04:43PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: > >> On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: > >> > test-qapi.py doesn't force a specific encoding for st

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-08 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: >> On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: >> > test-qapi.py doesn't force a specific encoding for stderr or >> > stdout, but the reference files used by check-qapi-schema are in

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-08 Thread Alex Bennée
Eduardo Habkost writes: > test-qapi.py doesn't force a specific encoding for stderr or > stdout, but the reference files used by check-qapi-schema are in > UTF-8. This breaks check-qapi-schema under certain circumstances > (e.g. if using the C locale and Python < 3.7). > > We need to make sure

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-07 Thread Eduardo Habkost
On Tue, May 07, 2019 at 03:13:45PM +0100, Daniel P. Berrangé wrote: > On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: > > test-qapi.py doesn't force a specific encoding for stderr or > > stdout, but the reference files used by check-qapi-schema are in > > UTF-8. This breaks check-

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2019 at 06:38:17PM -0300, Eduardo Habkost wrote: > test-qapi.py doesn't force a specific encoding for stderr or > stdout, but the reference files used by check-qapi-schema are in > UTF-8. This breaks check-qapi-schema under certain circumstances > (e.g. if using the C locale and Py

Re: [Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-06 Thread Philippe Mathieu-Daudé
On 5/6/19 11:38 PM, Eduardo Habkost wrote: > test-qapi.py doesn't force a specific encoding for stderr or > stdout, but the reference files used by check-qapi-schema are in > UTF-8. This breaks check-qapi-schema under certain circumstances > (e.g. if using the C locale and Python < 3.7). > > We n

[Qemu-devel] [PATCH] tests: Force Python I/O encoding for check-qapi-schema

2019-05-06 Thread Eduardo Habkost
test-qapi.py doesn't force a specific encoding for stderr or stdout, but the reference files used by check-qapi-schema are in UTF-8. This breaks check-qapi-schema under certain circumstances (e.g. if using the C locale and Python < 3.7). We need to make sure test-qapi.py always generate UTF-8 out