Dear Peter,
Peter Maydell writes:
> Are you planning to send a v2 of this patch? I was hoping we could
> fix the non-deleted logfiles for qemu 2.7.0 but it's getting a bit
> late in the cycle...
I'll try cooking up a version that's good enough for 2.7. I expected it
to land in 2.8 so I wasn't i
On 15 August 2016 at 19:24, Sascha Silbe wrote:
> Dear Peter,
>
> Peter Maydell writes:
>
>> On 15 July 2016 at 17:24, Sascha Silbe wrote:
> [...]
>>> Instead of hard-coding the paths, create a temporary directory using
>>> g_dir_make_tmp() and clean it up afterwards.
>>>
>>> Fixes: f6880b7f ("q
On 15 August 2016 at 19:24, Sascha Silbe wrote:
> Peter Maydell writes:
>> On 15 July 2016 at 17:24, Sascha Silbe wrote:
> [...]
>>> +static void rmtree(gchar const *root)
> [...]
>> I don't really like spawning rm here for this. We know we
>> don't have any subdirectories here so we can just
>
Dear Peter,
Peter Maydell writes:
> On 15 July 2016 at 17:24, Sascha Silbe wrote:
[...]
>> Instead of hard-coding the paths, create a temporary directory using
>> g_dir_make_tmp() and clean it up afterwards.
>>
>> Fixes: f6880b7f ("qemu-log: support simple pid substitution for logs")
>> Signed-
On 15 July 2016 at 17:24, Sascha Silbe wrote:
> Since f6880b7f [qemu-log: support simple pid substitution for logs],
> test-logging creates files with hard-coded names in /tmp. In the best
> case, this prevents multiple developers from running "make check" on
> the same machine. In the worst case,
Since f6880b7f [qemu-log: support simple pid substitution for logs],
test-logging creates files with hard-coded names in /tmp. In the best
case, this prevents multiple developers from running "make check" on
the same machine. In the worst case, it allows for symlink attacks,
enabling an attacker to
