On 04/04/16 20:53, Stefan Weil wrote:
> Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
>> On 04/04/16 14:56, Stefan Weil wrote:
> [...]
>>> There is indeed a regression in the current code. Commit
>>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>>> which includes assert.h be
Am 04.04.2016 um 15:22 schrieb Sergey Fedorov:
> On 04/04/16 14:56, Stefan Weil wrote:
[...]
>> There is indeed a regression in the current code. Commit
>> d38ea87ac54af64ef611de434d07c12dc0399216 added an include statement
>> which includes assert.h before NDEBUG is defined. This is wrong and
>> n
On 04/04/16 14:56, Stefan Weil wrote:
> Am 04.04.2016 um 13:05 schrieb Sergey Fedorov:
>> From: Sergey Fedorov
>>
>> assert() always evaluates its argument so there's no need to #ifdef the
>> definitions which is only used for assert(). Actually, doing so
>> generates a compilation warning which i
Am 04.04.2016 um 13:05 schrieb Sergey Fedorov:
> From: Sergey Fedorov
>
> assert() always evaluates its argument so there's no need to #ifdef the
> definitions which is only used for assert(). Actually, doing so
> generates a compilation warning which is treated as an error in QEMU
> build by defa
From: Sergey Fedorov
assert() always evaluates its argument so there's no need to #ifdef the
definitions which is only used for assert(). Actually, doing so
generates a compilation warning which is treated as an error in QEMU
build by default. Let compiler sort out and eliminate unnecessary
local
