[Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-15 Thread Alex Bennée
This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. Signed-off-by: Alex Bennée --- v2: - hoist up into translate-all.c - don't use pointless glib

Re: [Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-14 Thread Alex Bennée
Richard Henderson writes: > On 07/11/2014 09:43 AM, Alex Bennée wrote: >> +/* if I could put this in a header easily */ >> +void tb_enable_perfmap(void); > > How about next to tb_flush in exec/exec-all.h? Including exec/exec-all.h trips up some sort of include prevention magic: CCvl.o

Re: [Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-11 Thread Richard Henderson
On 07/11/2014 09:43 AM, Alex Bennée wrote: > +/* if I could put this in a header easily */ > +void tb_enable_perfmap(void); How about next to tb_flush in exec/exec-all.h? > + > +void tb_enable_perfmap(void) { Watch the { placement. > +gchar * map_file = g_strdup_printf("/tmp/perf-%d.map

[Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-11 Thread Alex Bennée
This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. Signed-off-by: Alex Bennée --- v2: - hoist up into translate-all.c - don't use pointless glib