Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-27 Thread Peter Maydell
On 27 September 2011 05:29, Andi Kleen wrote: > Peter Maydell writes: >> The answer is that the edge cases basically never match. No CPU >> architecture does handling of NaNs and input denormals and output >> denormals and underflow checks and all the rest of it in exactly >> the same way as anyb

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Andi Kleen
Peter Maydell writes: > > The answer is that the edge cases basically never match. No CPU > architecture does handling of NaNs and input denormals and output > denormals and underflow checks and all the rest of it in exactly > the same way as anybody else. (In particular x86 is pretty crazy, Can

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Avi Kivity
On 09/26/2011 11:19 PM, Peter Maydell wrote: On 26 September 2011 20:52, Avi Kivity wrote: > Why do floating point ops need helpers? At least if all the edge cases > match? (i.e. NaNs and denormals) The answer is that the edge cases basically never match. Surely they do when host == target

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Avi Kivity
On 09/26/2011 10:53 PM, Richard Henderson wrote: On 09/26/2011 12:52 PM, Avi Kivity wrote: > Why do floating point ops need helpers? Because TCG doesn't do any native floating point. Well, it could be made to do it. -- I have a truly marvellous patch that fixes the bug which this signature

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Peter Maydell
On 26 September 2011 20:52, Avi Kivity wrote: > Why do floating point ops need helpers?  At least if all the edge cases > match? (i.e. NaNs and denormals) The answer is that the edge cases basically never match. No CPU architecture does handling of NaNs and input denormals and output denormals an

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Richard Henderson
On 09/26/2011 12:52 PM, Avi Kivity wrote: > Why do floating point ops need helpers? Because TCG doesn't do any native floating point. r~

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Avi Kivity
On 09/26/2011 10:43 PM, Richard Henderson wrote: On 09/26/2011 10:41 AM, Avi Kivity wrote: > Native tcg ops for common vector instructions would probably be quite a speedup. It's very possible to simply open-code many of the vector operations. I've done a port of qemu to the SPU (aka Cell) pr

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Richard Henderson
On 09/26/2011 10:41 AM, Avi Kivity wrote: > Native tcg ops for common vector instructions would probably be quite a > speedup. It's very possible to simply open-code many of the vector operations. I've done a port of qemu to the SPU (aka Cell) processor. This core has no scalar operations; all

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Avi Kivity
On 09/26/2011 11:15 AM, Laurent Desnogues wrote: On Mon, Sep 26, 2011 at 10:01 AM, Mulyadi Santosa wrote: > Hi... > > On Mon, Sep 26, 2011 at 14:46, Jan Kiszka wrote: >> This increases the overhead of frequently executed helpers. >> >> Signed-off-by: Jan Kiszka > > IMHO, stack protector s

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Laurent Desnogues
On Mon, Sep 26, 2011 at 10:01 AM, Mulyadi Santosa wrote: > Hi... > > On Mon, Sep 26, 2011 at 14:46, Jan Kiszka wrote: >> This increases the overhead of frequently executed helpers. >> >> Signed-off-by: Jan Kiszka > > IMHO, stack protector setup put more stuffs during epilogue, but quite > likely

Re: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Mulyadi Santosa
Hi... On Mon, Sep 26, 2011 at 14:46, Jan Kiszka wrote: > This increases the overhead of frequently executed helpers. > > Signed-off-by: Jan Kiszka IMHO, stack protector setup put more stuffs during epilogue, but quite likely it is negligible unless it cause too much L1 cache misses. So, I think

[Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions

2011-09-26 Thread Jan Kiszka
This increases the overhead of frequently executed helpers. Signed-off-by: Jan Kiszka --- Maybe this should be applied to more hot-path functions, but I haven't done any thorough analysis yet. Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.ta