Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-31 Thread Laurent Vivier
Le 31/05/2018 à 03:13, Richard Henderson a écrit : > Do the cast to uintptr_t within the helper, so that the compiler > can type check the pointer argument. We can also do some more > sanity checking of the index argument. > > Signed-off-by: Richard Henderson > --- > include/exec/gen-icount.h

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread Richard Henderson
On 05/30/2018 06:13 PM, Richard Henderson wrote: > +void tcg_gen_exit_tb(TranslationBlock *tb, unsigned idx) > +{ > +uintptr_t val = (uintptr_t)tb + idx; > + > +if (tb == NULL) { > +tcg_debug_assert(idx == 0); > +} else if (idx <= 1) { > +/* This is an exit following a g

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180531011321.3119-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately === TEST SCRIPT BEGIN === #!/bin/bash # Testing script

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread no-reply
: Pass tb and index to tcg_gen_exit_tb separately === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-mingw@fedora === TEST SCRIPT END === Updating

[Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread Richard Henderson
Do the cast to uintptr_t within the helper, so that the compiler can type check the pointer argument. We can also do some more sanity checking of the index argument. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/tcg-op.h | 17 +