[Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-09 Thread Richard Henderson
The addition of MO_AMASK means that places that used inverted masks need to be changed to use positive masks, and places that failed to mask the intended bits need updating. Cc: Yongbok Kim Signed-off-by: Richard Henderson --- This should fix the problem you found while testing the mipsr6 unali

Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-08 Thread Richard Henderson
On 06/08/2015 04:10 AM, Yongbok Kim wrote: On 01/06/2015 16:28, Richard Henderson wrote: On 06/01/2015 02:42 AM, Yongbok Kim wrote: I have noticed that you haven't changed it for the tci, is it deliberate? Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st names correctly

Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-08 Thread Yongbok Kim
On 01/06/2015 16:28, Richard Henderson wrote: > On 06/01/2015 02:42 AM, Yongbok Kim wrote: >> I have noticed that you haven't changed it for the tci, is it deliberate? >> Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st >> names correctly but hex code will be printed out. >

Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-01 Thread Richard Henderson
On 06/01/2015 02:42 AM, Yongbok Kim wrote: > I have noticed that you haven't changed it for the tci, is it deliberate? > Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st > names correctly but hex code will be printed out. Correct on both counts. I'll get that fixed up too.

Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-01 Thread Yongbok Kim
On 29/05/2015 18:35, Richard Henderson wrote: > The addition of MO_AMASK means that places that used inverted masks > need to be changed to use positive masks, and places that failed to > mask the intended bits need updating. > > Cc: Yongbok Kim > Signed-off-by: Richard Henderson > --- > > This

[Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-05-29 Thread Richard Henderson
The addition of MO_AMASK means that places that used inverted masks need to be changed to use positive masks, and places that failed to mask the intended bits need updating. Cc: Yongbok Kim Signed-off-by: Richard Henderson --- This should fix the problem you found while testing the mipsr6 unali