Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-08 Thread Philippe Mathieu-Daudé
On 2/8/19 5:52 PM, Richard Henderson wrote: > On 2/8/19 2:41 AM, Philippe Mathieu-Daudé wrote: >> Not related to this patch content, but I'm wondering why, TCGLabels >> never get freed? > > They are allocated with tcg_malloc, which is a pool allocator. The entire > pool > is freed after each TB

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-08 Thread Richard Henderson
On 2/8/19 2:41 AM, Philippe Mathieu-Daudé wrote: > Not related to this patch content, but I'm wondering why, TCGLabels > never get freed? They are allocated with tcg_malloc, which is a pool allocator. The entire pool is freed after each TB is compiled. r~

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-08 Thread Philippe Mathieu-Daudé
Hi Richard, On 2/8/19 4:55 AM, Richard Henderson wrote: > Currently, a jump to a label that is not defined anywhere will > be emitted not be relocated. This results in a jump to a random > jump target. With tcg debugging, print a diagnostic to the -d op > file and abort. > > This could help deb

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Message-id

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Type: series

[Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread Richard Henderson
Currently, a jump to a label that is not defined anywhere will be emitted not be relocated. This results in a jump to a random jump target. With tcg debugging, print a diagnostic to the -d op file and abort. This could help debug or detect errors like c2d9644e6d ("target/arm: Fix crash on condit