Re: [Qemu-devel] [PATCH] tcg/i386: Fix dup_vec in non-AVX2 codepath

2018-05-04 Thread Richard Henderson
On 05/04/2018 08:34 AM, Peter Maydell wrote: > The VPUNPCKLD* instructions are all "non-destructive source", > indicated by "NDS" in the encoding string in the x86 ISA manual. > This means that they take two source operands, one of which is > encoded in the VEX. field. We were incorrectly treat

[Qemu-devel] [PATCH] tcg/i386: Fix dup_vec in non-AVX2 codepath

2018-05-04 Thread Peter Maydell
The VPUNPCKLD* instructions are all "non-destructive source", indicated by "NDS" in the encoding string in the x86 ISA manual. This means that they take two source operands, one of which is encoded in the VEX. field. We were incorrectly treating them as if they were destructive-source and passi