Re: [Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-28 Thread Richard Henderson
On 02/28/2014 12:33 AM, Claudio Fontana wrote: > ping? > > Richard, do you prefer to spin your polishing from last year instead? I do prefer my patch set over this. >> +INSN_IMM = 0x1000, /* 3.4.1, 3.4.4 - add/sub and logical */ >> +INSN_SHIFT = 0x1ac02000, /* 3.5.8 - Data

Re: [Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-28 Thread Claudio Fontana
ping? Richard, do you prefer to spin your polishing from last year instead? We can start with the pure refactoring patch as you suggested, and in this case, you could look here for some things I'd look for, in particular that we move gradually, that we group instructions that are handled in a sim

[Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-07 Thread Claudio Fontana
From: Claudio Fontana this is general polishing for tcg/aarch64, removing the inline magic insn numbers, and putting up enums for intruction classes and subclasses in their stead. Signed-off-by: Claudio Fontana Tested-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 528