Re: [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)

2015-03-07 Thread Bastian Koppelmann
On 03/07/2015 12:34 PM, Peter Maydell wrote: On 7 March 2015 at 18:33, Stefan Weil wrote: diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c index ed26b30..52ad80b 100644 --- a/target-tricore/op_helper.c +++ b/target-tricore/op_helper.c @@ -1244,9 +1244,9 @@ uint64_t helper_

Re: [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)

2015-03-07 Thread Peter Maydell
On 7 March 2015 at 18:33, Stefan Weil wrote: > diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c > index ed26b30..52ad80b 100644 > --- a/target-tricore/op_helper.c > +++ b/target-tricore/op_helper.c > @@ -1244,9 +1244,9 @@ uint64_t helper_dvinit_b_13(CPUTriCoreState *env, > uin

Re: [Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)

2015-03-07 Thread Bastian Koppelmann
Hi Stefan, On 03/07/2015 09:33 AM, Stefan Weil wrote: clang report: target-tricore/op_helper.c:1247:24: warning: taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int') has no effect [-Wabsolute-value] target-tricore/op_helper.c:1248:25: warning: taking the absolute

[Qemu-devel] [PATCH] target-tricore: Fix two helper functions (clang warnings)

2015-03-07 Thread Stefan Weil
clang report: target-tricore/op_helper.c:1247:24: warning: taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int') has no effect [-Wabsolute-value] target-tricore/op_helper.c:1248:25: warning: taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int') has