Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Dennis Luehring
Am 25.08.2015 um 20:09 schrieb Richard Henderson: But you're right, it would be nice to put together a coherent set of benchmarks. Ideally, a guest kernel plus minimal ramdisk with the tests pre-loaded so that we can boot and run ./benchmark at the prompt. That's the sort of thing we can easily

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Dennis Luehring
Am 25.08.2015 um 20:09 schrieb Richard Henderson: On 08/25/2015 07:37 AM, Dennis Luehring wrote: > Am 25.08.2015 um 16:25 schrieb Richard Henderson: >> Er, no, it should. The primary vector by which I expect improvement is via not >> encoding dmmu.mmu_primary_context into the TB flags. I.e. AS

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Richard Henderson
On 08/25/2015 07:37 AM, Dennis Luehring wrote: Am 25.08.2015 um 16:25 schrieb Richard Henderson: Er, no, it should. The primary vector by which I expect improvement is via not encoding dmmu.mmu_primary_context into the TB flags. I.e. ASI_DMMU, which sun4u certainly uses. The fact that the pat

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Artyom Tarasenko
On Tue, Aug 25, 2015 at 4:25 PM, Richard Henderson wrote: > On 08/24/2015 11:44 PM, Artyom Tarasenko wrote: >> >> This is very surprising: the patch should have no effect on a sun4u >> machine. > > > Er, no, it should. The primary vector by which I expect improvement is via > not encoding dmmu.mm

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Dennis Luehring
Am 25.08.2015 um 16:25 schrieb Richard Henderson: Er, no, it should. The primary vector by which I expect improvement is via not encoding dmmu.mmu_primary_context into the TB flags. I.e. ASI_DMMU, which sun4u certainly uses. The fact that the patch_also_ fixes a sun4v problem is secondary.

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Richard Henderson
On 08/24/2015 11:44 PM, Artyom Tarasenko wrote: This is very surprising: the patch should have no effect on a sun4u machine. Er, no, it should. The primary vector by which I expect improvement is via not encoding dmmu.mmu_primary_context into the TB flags. I.e. ASI_DMMU, which sun4u certain

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-25 Thread Dennis Luehring
Am 25.08.2015 um 08:44 schrieb Artyom Tarasenko: >your patch gives the worst result in stream benchmark but nearly the best in >pugixml compile times and prime.c runtime >every tried patch or branch nearly halfs the speed of the stream benchmark >comapred to qemu-git-master This is very surprisi

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-24 Thread Artyom Tarasenko
Hi Dennis, On Tue, Aug 25, 2015 at 7:45 AM, Dennis Luehring wrote: > Am 25.08.2015 um 06:19 schrieb Richard Henderson: >> >> Artyom and Dennis, I'm hoping that this will help with some of your >> translation performance problems. I don't currently have a sparc64 >> kernel set up for booting, bu

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-24 Thread Artyom Tarasenko
Hi Richard, On Tue, Aug 25, 2015 at 6:19 AM, Richard Henderson wrote: > Doing this instead of saving the raw PS_PRIV and TL. This means > that all nucleus mode TBs (TL > 0) can be shared. This fixes a > bug in that we didn't include HS_PRIV in the TB flags, and so could > produce incorrect TB m

Re: [Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-24 Thread Dennis Luehring
Am 25.08.2015 um 06:19 schrieb Richard Henderson: Artyom and Dennis, I'm hoping that this will help with some of your translation performance problems. I don't currently have a sparc64 kernel set up for booting, but I did smoke test this with openbios, and even there it reduced the number of TBs

[Qemu-devel] [PATCH] target-sparc: Store mmu index in TB flags

2015-08-24 Thread Richard Henderson
Doing this instead of saving the raw PS_PRIV and TL. This means that all nucleus mode TBs (TL > 0) can be shared. This fixes a bug in that we didn't include HS_PRIV in the TB flags, and so could produce incorrect TB matches for hypervisor state. The LSU and DMMU states were unused by the transla