Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-28 Thread Aurelien Jarno
On Tue, Aug 27, 2013 at 05:48:36PM +0100, Yongbok Kim wrote: > From: James Hogan > > In get_physical_address() is a qemu_log() call inside an #if 0 block. > When enabled the following build error is hit: > > target-mips/helper.c In function ‘get_physical_address’: > target-mips/helper.c:220:13:

Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-28 Thread James Hogan
On 27/08/13 20:48, Richard Henderson wrote: > On 08/27/2013 09:48 AM, Yongbok Kim wrote: >> #if 0 >> -qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n", >> +qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n", >> address, rw, access_type, *physical, *pro

Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-27 Thread Richard Henderson
On 08/27/2013 09:48 AM, Yongbok Kim wrote: > #if 0 > -qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n", > +qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n", > address, rw, access_type, *physical, *prot, ret); > #endif While by itself correct, consi

[Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-27 Thread Yongbok Kim
From: James Hogan In get_physical_address() is a qemu_log() call inside an #if 0 block. When enabled the following build error is hit: target-mips/helper.c In function ‘get_physical_address’: target-mips/helper.c:220:13: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5