Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-28 Thread Richard Henderson
On 11/27/2016 11:53 AM, Laurent Vivier wrote: >> tcg_gen_andi_i32(tmp, tmp, 31); >> > mask = tcg_const_i32(0x7fffu); >> > tcg_gen_shr_i32(mask, mask, tmp); >> > +if (!TCGV_IS_UNUSED(tlen)) { >> > +tcg_gen_mov_i32(tlen, tmp); > W

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-27 Thread Laurent Vivier
Le 15/11/2016 à 21:44, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index bc6ec39..ed40ade 100644 > --- a/target-m68k/translate.c > +++ b/target-m68k/translate.c > @@ -3913,7 +3913,14 @@ DISAS_INSN(bfop_reg) >

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Andreas Schwab
On Nov 15 2016, Richard Henderson wrote: > On 11/15/2016 10:12 PM, Laurent Vivier wrote: >> Le 15/11/2016 à 22:07, Laurent Vivier a écrit : >>> Le 15/11/2016 à 21:44, Richard Henderson a écrit : @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env) INSN(bfop_reg, eac0,

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 22:21, Richard Henderson a écrit : > On 11/15/2016 10:07 PM, Laurent Vivier wrote: >> Le 15/11/2016 à 21:44, Richard Henderson a écrit : >>> Signed-off-by: Richard Henderson >>> --- >>> >>> I've started a glibc test run with this, but I don't expect overmuch. >>> The only applicati

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
On 11/15/2016 10:07 PM, Laurent Vivier wrote: Le 15/11/2016 à 21:44, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- I've started a glibc test run with this, but I don't expect overmuch. The only applications I can see are "bfffo *,0,32,dN" which isn't exactly exhaustive. Pro

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
On 11/15/2016 10:12 PM, Laurent Vivier wrote: Le 15/11/2016 à 22:07, Laurent Vivier a écrit : Le 15/11/2016 à 21:44, Richard Henderson a écrit : @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env) INSN(bfop_reg, eac0, fff8, BITFIELD); /* bfchg */ INSN(bfop_mem, ecc0,

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 22:07, Laurent Vivier a écrit : > Le 15/11/2016 à 21:44, Richard Henderson a écrit : >> @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env) >> INSN(bfop_reg, eac0, fff8, BITFIELD); /* bfchg */ >> INSN(bfop_mem, ecc0, ffc0, BITFIELD); /* bfclr */ >>

Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Laurent Vivier
Le 15/11/2016 à 21:44, Richard Henderson a écrit : > Signed-off-by: Richard Henderson > --- > > I've started a glibc test run with this, but I don't expect overmuch. > The only applications I can see are "bfffo *,0,32,dN" which isn't > exactly exhaustive. Probably better to hand craft some tests

[Qemu-devel] [PATCH] target-m68k: Implement bfffo

2016-11-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- I've started a glibc test run with this, but I don't expect overmuch. The only applications I can see are "bfffo *,0,32,dN" which isn't exactly exhaustive. Probably better to hand craft some tests vs real hardware. Considering the prevelance of small helper