[Qemu-devel] [PATCH] target-i386: update hflags on Hypervisor.framework

2018-01-11 Thread Paolo Bonzini
This ensures that x86_cpu_dump_state shows registers with the correct size. Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86hvf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c index 71c0515073..7803e09a28 100644 --- a/

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-16 Thread Paolo Bonzini
Il 15/09/2014 22:01, Richard Henderson ha scritto: >> > @@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong >> > ptr, int data32) >> > cpu_stw_data(env, ptr + 10, 0); >> > cpu_stw_data(env, ptr + 12, 0); >> > } >> > +update_fp_status(env); >> > } > W

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
I suggest using cpu_set_fpuc() like cpu_set_mxcsr(). On Tue, Sep 16, 2014 at 1:51 PM, TeLeMan wrote: > On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: >> update_fp_status() should be used after all of env->fpuc changes : >> helper_fldcw(), helper_fninit(), helper_fldenv() >> ,helper_fxrstor(), h

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
On Tue, Sep 16, 2014 at 1:42 PM, TeLeMan wrote: > update_fp_status() should be used after all of env->fpuc changes : > helper_fldcw(), helper_fninit(), helper_fldenv() > ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). missing one: x86_cpu_gdb_write_register(). > > On Mon, Se

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread TeLeMan
update_fp_status() should be used after all of env->fpuc changes : helper_fldcw(), helper_fninit(), helper_fldenv() ,helper_fxrstor(), helper_fsave(), x86_cpu_reset(), cpu_post_load(). On Mon, Sep 15, 2014 at 7:17 PM, Pavel Dovgalyuk wrote: > This patch adds calls to update_fp_status() function f

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread Richard Henderson
On 09/15/2014 04:17 AM, Pavel Dovgalyuk wrote: > @@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong ptr, > int data32) > cpu_stw_data(env, ptr + 10, 0); > cpu_stw_data(env, ptr + 12, 0); > } > +update_fp_status(env); > } Why does this need to updat

Re: [Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread Paolo Bonzini
Il 15/09/2014 13:17, Pavel Dovgalyuk ha scritto: > This patch adds calls to update_fp_status() function from several > places where FPU state is changed. These calls update status of > softfloat library and prevent bugs caused by non-coherent rounding > settings of the FPU and softfloat. > > Signe

[Qemu-devel] [PATCH] target-i386: update fp status fix

2014-09-15 Thread Pavel Dovgalyuk
This patch adds calls to update_fp_status() function from several places where FPU state is changed. These calls update status of softfloat library and prevent bugs caused by non-coherent rounding settings of the FPU and softfloat. Signed-off-by: Pavel Dovgalyuk --- target-i386/cpu.c|

Re: [Qemu-devel] [PATCH] target-i386 update

2014-05-15 Thread Peter Maydell
On 13 May 2014 00:32, Richard Henderson wrote: > On 05/12/2014 02:28 PM, Richard Henderson wrote: >> A long-delayed fix for the changed handling of the Z flag. >> >> >> r~ >> >> >> The following changes since commit 06b4f00d53637f2c16a62c2cbaa30bffb045cf88: >> >> Merge remote-tracking branch 're

Re: [Qemu-devel] [PATCH] target-i386 update

2014-05-12 Thread Richard Henderson
On 05/12/2014 02:28 PM, Richard Henderson wrote: > A long-delayed fix for the changed handling of the Z flag. > > > r~ > > > The following changes since commit 06b4f00d53637f2c16a62c2cbaa30bffb045cf88: > > Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging > (2014-05

[Qemu-devel] [PATCH] target-i386 update

2014-05-12 Thread Richard Henderson
A long-delayed fix for the changed handling of the Z flag. r~ The following changes since commit 06b4f00d53637f2c16a62c2cbaa30bffb045cf88: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-09 15:46:34 +0100) are available in the git repository at: git