Re: [Qemu-devel] [PATCH] target-i386: fix order of checks in cpu_get_phys_page_debug

2013-04-04 Thread Max Filippov
On Fri, Apr 5, 2013 at 3:13 AM, Brendan Dolan-Gavitt wrote: > In target-i386 cpu_get_phys_page_debug, the CR4_PAE bit is checked > before CR0_PG. This means that if paging is disabled but the PAE bit has > been set in CR4, cpu_get_phys_page_debug will return the wrong result > (it will try to tran

[Qemu-devel] [PATCH] target-i386: fix order of checks in cpu_get_phys_page_debug

2013-04-04 Thread Brendan Dolan-Gavitt
In target-i386 cpu_get_phys_page_debug, the CR4_PAE bit is checked before CR0_PG. This means that if paging is disabled but the PAE bit has been set in CR4, cpu_get_phys_page_debug will return the wrong result (it will try to translate the address as virtual rather than using it as a physical addre