Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

2014-02-17 Thread Kevin Wolf
Am 17.02.2014 um 11:47 hat Peter Maydell geschrieben: > On 17 February 2014 10:14, Kevin Wolf wrote: > > Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben: > >> Commit 1b90d56e changed the implementation of in/out imm to not assign > >> the accessed port number to cpu_T[0] as it appeared unnecessa

Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

2014-02-17 Thread Peter Maydell
On 17 February 2014 10:14, Kevin Wolf wrote: > Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben: >> Commit 1b90d56e changed the implementation of in/out imm to not assign >> the accessed port number to cpu_T[0] as it appeared unnecessary. >> However, currently gen_check_io() makes use of cpu_T[0]

Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

2014-02-17 Thread Kevin Wolf
Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben: > Commit 1b90d56e changed the implementation of in/out imm to not assign > the accessed port number to cpu_T[0] as it appeared unnecessary. > However, currently gen_check_io() makes use of cpu_T[0] to implement the > I/O bitmap checks, so it's in f

[Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

2014-01-24 Thread Kevin Wolf
Commit 1b90d56e changed the implementation of in/out imm to not assign the accessed port number to cpu_T[0] as it appeared unnecessary. However, currently gen_check_io() makes use of cpu_T[0] to implement the I/O bitmap checks, so it's in fact still used and the change broke the check, leading to #