Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Peter Maydell
On 23 December 2013 14:15, Michael S. Tsirkin wrote: > OK, ack my patch then? I'll add a comment > /* TODO: remove when we support more CPUs. */ Post an updated patch (with TODO comments in both places) and I'll ack it. thanks -- PMM

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Michael S. Tsirkin
On Mon, Dec 23, 2013 at 12:37:41PM +, Peter Maydell wrote: > On 23 December 2013 11:56, Michael S. Tsirkin wrote: > > commit 5ce4f35781028ce1aee3341e6002f925fdc7aaf3 > > "target-arm: A64: add set_pc cpu method" > > > > introduces an array aarch64_cpus which is zero > > size if this code is

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Michael S. Tsirkin
On Mon, Dec 23, 2013 at 01:41:50PM +, Peter Maydell wrote: > On 23 December 2013 13:32, Stefan Weil wrote: > > Am 23.12.2013 13:59, schrieb Peter Maydell: > >> On 23 December 2013 12:50, Paolo Bonzini wrote: > >>> Il 23/12/2013 13:37, Peter Maydell ha scritto: > At a minimum, if we take

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Peter Maydell
On 23 December 2013 13:45, Andreas Färber wrote: > While I share your sentiment wrt this workaround, what's the status of > getting a real 64-bit CPU applied? Isn't the Cortex-A57/A53 CPU > independent of whether we have all MPCore etc. pieces in place? That > would seem the most elegant solution

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Andreas Färber
Am 23.12.2013 13:37, schrieb Peter Maydell: > On 23 December 2013 11:56, Michael S. Tsirkin wrote: >> commit 5ce4f35781028ce1aee3341e6002f925fdc7aaf3 >> "target-arm: A64: add set_pc cpu method" >> >> introduces an array aarch64_cpus which is zero >> size if this code is built without CONFIG_US

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Peter Maydell
On 23 December 2013 13:32, Stefan Weil wrote: > Am 23.12.2013 13:59, schrieb Peter Maydell: >> On 23 December 2013 12:50, Paolo Bonzini wrote: >>> Il 23/12/2013 13:37, Peter Maydell ha scritto: At a minimum, if we take this approach we should add TODO comments to the effect that the NUL

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Stefan Weil
Am 23.12.2013 13:59, schrieb Peter Maydell: > On 23 December 2013 12:50, Paolo Bonzini wrote: >> Il 23/12/2013 13:37, Peter Maydell ha scritto: >>> At a minimum, if we take this approach we should add TODO comments >>> to the effect that the NULL terminator and the if() can be removed >>> when the

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Peter Maydell
On 23 December 2013 12:50, Paolo Bonzini wrote: > Il 23/12/2013 13:37, Peter Maydell ha scritto: >> At a minimum, if we take this approach we should add TODO comments >> to the effect that the NULL terminator and the if() can be removed >> when the first real AArch64 CPU is added. >> >> I think I'

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Paolo Bonzini
Il 23/12/2013 13:37, Peter Maydell ha scritto: > At a minimum, if we take this approach we should add TODO comments > to the effect that the NULL terminator and the if() can be removed > when the first real AArch64 CPU is added. > > I think I'd rather put the if (!info->name) continue into the fun

Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Peter Maydell
On 23 December 2013 11:56, Michael S. Tsirkin wrote: > commit 5ce4f35781028ce1aee3341e6002f925fdc7aaf3 > "target-arm: A64: add set_pc cpu method" > > introduces an array aarch64_cpus which is zero > size if this code is built without CONFIG_USER_ONLY. > In particular an attempt to iterate over

[Qemu-devel] [PATCH] target-arm: fix build on fedora

2013-12-23 Thread Michael S. Tsirkin
commit 5ce4f35781028ce1aee3341e6002f925fdc7aaf3 "target-arm: A64: add set_pc cpu method" introduces an array aarch64_cpus which is zero size if this code is built without CONFIG_USER_ONLY. In particular an attempt to iterate over this array produces a warning: CCaarch64-softmmu/target-ar